check status after installation

pgayvallet · pgayvallet · commit b9145effcdc6 · 2024-11-18T09:12:40.000+01:00
diff --git a/x-pack/plugins/ai_infra/product_doc_base/public/services/installation/installation_service.test.ts b/x-pack/plugins/ai_infra/product_doc_base/public/services/installation/installation_service.test.ts
@@ -37,18 +37,30 @@ describe('InstallationService', () => {
     });
   });
   describe('#install', () => {
+    beforeEach(() => {
+      http.post.mockResolvedValue({ installed: true });
+    });
+
     it('calls the endpoint with the right parameters', async () => {
       await service.install();
       expect(http.post).toHaveBeenCalledTimes(1);
       expect(http.post).toHaveBeenCalledWith(INSTALL_ALL_API_PATH);
     });
     it('returns the value from the server', async () => {
-      const expected = { stubbed: true };
+      const expected = { installed: true };
       http.post.mockResolvedValue(expected);
 
       const response = await service.install();
       expect(response).toEqual(expected);
     });
+    it('throws when the server returns installed: false', async () => {
+      const expected = { installed: false };
+      http.post.mockResolvedValue(expected);
+
+      await expect(service.install()).rejects.toThrowErrorMatchingInlineSnapshot(
+        `"Installation did not complete successfully"`
+      );
+    });
   });
   describe('#uninstall', () => {
     it('calls the endpoint with the right parameters', async () => {
diff --git a/x-pack/plugins/ai_infra/product_doc_base/public/services/installation/installation_service.ts b/x-pack/plugins/ai_infra/product_doc_base/public/services/installation/installation_service.ts
@@ -27,7 +27,11 @@ export class InstallationService {
   }
 
   async install(): Promise<PerformInstallResponse> {
-    return await this.http.post<PerformInstallResponse>(INSTALL_ALL_API_PATH);
+    const response = await this.http.post<PerformInstallResponse>(INSTALL_ALL_API_PATH);
+    if (!response.installed) {
+      throw new Error('Installation did not complete successfully');
+    }
+    return response;
   }
 
   async uninstall(): Promise<UninstallResponse> {
diff --git a/x-pack/plugins/ai_infra/product_doc_base/server/routes/installation.ts b/x-pack/plugins/ai_infra/product_doc_base/server/routes/installation.ts
@@ -73,9 +73,12 @@ export const registerInstallationRoutes = ({
         wait: true,
       });
 
+      // check status after installation in case of failure
+      const { status } = await documentationManager.getStatus();
+
       return res.ok<PerformInstallResponse>({
         body: {
-          installed: true,
+          installed: status === 'installed',
         },
       });
     }

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,11 @@ export class InstallationService {`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`async install(): Promise<PerformInstallResponse> {`
`30`		`- return await this.http.post<PerformInstallResponse>(INSTALL_ALL_API_PATH);`
	`30`	`+ const response = await this.http.post<PerformInstallResponse>(INSTALL_ALL_API_PATH);`
	`31`	`+ if (!response.installed) {`
	`32`	`+ throw new Error('Installation did not complete successfully');`
	`33`	`+ }`
	`34`	`+ return response;`
`31`	`35`	`}`
`32`	`36`
`33`	`37`	`async uninstall(): Promise<UninstallResponse> {`