Skip to content

Commit b84819d

Browse files
andreadelrioandreadelrio
authored
Merge pull request #1 from mikecote/pr/63515
Fix functional tests for alerting UI enhancements
2 parents fa62385 + 4275ae9 commit b84819d

2 files changed

Lines changed: 16 additions & 16 deletions

File tree

‎x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_list/components/collapsed_item_actions.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export const CollapsedItemActions: React.FunctionComponent<ComponentOpts> = ({
7878
disabled={!canSave}
7979
compressed
8080
checked={!item.enabled}
81-
data-test-subj="enableSwitch"
81+
data-test-subj="disableSwitch"
8282
onChange={async () => {
8383
if (item.enabled) {
8484
await disableAlert(item);

‎x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts.ts‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -343,15 +343,15 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
343343

344344
await testSubjects.click('collapsedItemActions');
345345

346-
await pageObjects.triggersActionsUI.toggleSwitch('enableSwitch');
346+
await pageObjects.triggersActionsUI.toggleSwitch('disableSwitch');
347347

348348
await pageObjects.triggersActionsUI.searchAlerts(createdAlert.name);
349349

350350
await testSubjects.click('collapsedItemActions');
351351

352-
const enableSwitchAfterDisable = await testSubjects.find('enableSwitch');
353-
const isChecked = await enableSwitchAfterDisable.getAttribute('aria-checked');
354-
expect(isChecked).to.eql('false');
352+
const disableSwitchAfterDisable = await testSubjects.find('disableSwitch');
353+
const isChecked = await disableSwitchAfterDisable.getAttribute('aria-checked');
354+
expect(isChecked).to.eql('true');
355355
});
356356

357357
it('should re-enable single alert', async () => {
@@ -361,21 +361,21 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
361361

362362
await testSubjects.click('collapsedItemActions');
363363

364-
await pageObjects.triggersActionsUI.toggleSwitch('enableSwitch');
364+
await pageObjects.triggersActionsUI.toggleSwitch('disableSwitch');
365365

366366
await pageObjects.triggersActionsUI.searchAlerts(createdAlert.name);
367367

368368
await testSubjects.click('collapsedItemActions');
369369

370-
await pageObjects.triggersActionsUI.toggleSwitch('enableSwitch');
370+
await pageObjects.triggersActionsUI.toggleSwitch('disableSwitch');
371371

372372
await pageObjects.triggersActionsUI.searchAlerts(createdAlert.name);
373373

374374
await testSubjects.click('collapsedItemActions');
375375

376-
const enableSwitchAfterReEnable = await testSubjects.find('enableSwitch');
377-
const isChecked = await enableSwitchAfterReEnable.getAttribute('aria-checked');
378-
expect(isChecked).to.eql('true');
376+
const disableSwitchAfterReEnable = await testSubjects.find('disableSwitch');
377+
const isChecked = await disableSwitchAfterReEnable.getAttribute('aria-checked');
378+
expect(isChecked).to.eql('false');
379379
});
380380

381381
it('should mute single alert', async () => {
@@ -507,9 +507,9 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
507507

508508
await testSubjects.click('collapsedItemActions');
509509

510-
const enableSwitch = await testSubjects.find('enableSwitch');
511-
const isChecked = await enableSwitch.getAttribute('aria-checked');
512-
expect(isChecked).to.eql('false');
510+
const disableSwitch = await testSubjects.find('disableSwitch');
511+
const isChecked = await disableSwitch.getAttribute('aria-checked');
512+
expect(isChecked).to.eql('true');
513513
});
514514

515515
it('should enable all selection', async () => {
@@ -532,9 +532,9 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
532532

533533
await testSubjects.click('collapsedItemActions');
534534

535-
const enableSwitch = await testSubjects.find('enableSwitch');
536-
const isChecked = await enableSwitch.getAttribute('aria-checked');
537-
expect(isChecked).to.eql('true');
535+
const disableSwitch = await testSubjects.find('disableSwitch');
536+
const isChecked = await disableSwitch.getAttribute('aria-checked');
537+
expect(isChecked).to.eql('false');
538538
});
539539

540540
it('should delete all selection', async () => {

0 commit comments

Comments
 (0)