Skip to content

Commit b31bcf9

Browse files
machadoummachadoum
authored
Merge branch '8.16' into backport/8.16/pr-199791
2 parents 5f89288 + f3f9ac9 commit b31bcf9

115 files changed

Lines changed: 3276 additions & 612 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎docs/CHANGELOG.asciidoc‎

Lines changed: 23 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -93,37 +93,36 @@ The 8.16.0 release includes the following known issues.
9393

9494
[discrete]
9595
[[known-199902]]
96-
.Stack Monitoring shows "Unable to load page error"
96+
.Stack Monitoring shows "Unable to load page" error
9797
[%collapsible]
9898
====
9999
*Details* +
100-
The Stack Monitoring pages Overview, Nodes, Logs can stop working with the error "Unable to load page error". The Stack trace mentions `TypeError: Cannot read properties of undefined (reading 'logsLocator')`.
100+
The Overview, Nodes, and Logs pages in Stack Monitoring show an "Unable to load page" error. The Stack trace mentions `TypeError: Cannot read properties of undefined (reading 'logsLocator')`.
101101
102102
*Workaround* +
103-
Disabling the `Set feature visibility > Logs` feature at Kibana Space settings level will prevent the error to occur. Please note the `Logs` feature will not be available on such space.
103+
Disabling the `Set feature visibility > Logs` feature at the Kibana Space settings level will prevent the error from occurring. Please note the `Logs` feature will not be available on those spaces.
104104
105-
It's also possible to `Observability > Logs` feature privilege to `None` on the role level - this will hide the `Logs` feature for individual users and prevent the error for these users as well.
105+
It's also possible to set the `Observability > Logs` feature privilege to `None` at the role level. This will hide the `Logs` feature from individual users and prevent the error for these users as well.
106106
107107
For more information, refer to {kibana-issue}199902[#199902].
108108
====
109109

110110
[discrete]
111111
[[known-199891-199892]]
112-
.Onboarding, tutorial of APM and OpenTelemetry and some "Beats Only" integrations will show the error "Unable to load page error"
112+
.Onboarding, tutorial of APM and OpenTelemetry and some "Beats Only" integrations shows "Unable to load page" error
113113
[%collapsible]
114114
====
115115
*Details* +
116-
Tutorials linked from the {kib} home page show an error "Unable to load page error". The Stack trace mentions `The above error occurred in tutorial_TutorialUi`.
116+
Tutorials linked from the {kib} home page show an "Unable to load page" error. The Stack trace mentions `The above error occurred in tutorial_TutorialUi`.
117117
118118
*Workaround* +
119-
The APM / OpenTelemetry tutorials represented a shortcut to get important parameters to use in the configuration files quickly.
120-
It is still possible to obtain the same parameters following the documentation tutorials of APM.
119+
The APM / OpenTelemetry tutorials represented a shortcut to quickly add important parameters to the configuration files.
120+
It is still possible to obtain the same parameters following the tutorials in the APM documentation.
121121
122122
More information can be found in the {observability-guide}/apm-collect-application-data.html[APM documentation] and the {observability-guide}/get-started-with-fleet-apm-server.html[Fleet documentation].
123123
124124
For information about how to create APM API keys, please check the {observability-guide}/apm-api-key.html#apm-create-an-api-key[API key documentation].
125125
126-
127126
For more information, refer to {kibana-issue}199891[#199891] and {kibana-issue}199892[#199892].
128127
====
129128

@@ -156,9 +155,22 @@ The Observability AI Assistant specific advanced setting for Logs index patterns
156155
//*Impact* +
157156
//!!TODO!!
158157
====
159-
160158

161-
159+
[float]
160+
[[breaking-changes-8.16.0]]
161+
=== Breaking changes
162+
163+
Breaking changes can prevent your application from optimal operation and performance.
164+
Before you upgrade to 8.16.0, review the breaking changes, then mitigate the impact to your application.
165+
166+
[discrete]
167+
.Updated request processing during shutdown.
168+
[%collapsible]
169+
====
170+
*Details* +
171+
During shutdown, {kib} now waits for all the ongoing requests to complete according to the `server.shutdownTimeout` setting. During that period, the incoming socket is closed and any new incoming requests are rejected. Before this update, new incoming requests received a response with the status code 503 and body `{"message": "Kibana is shutting down and not accepting new incoming requests"}`. For more information, refer to {kibana-pull}180986[#180986].
172+
====
173+
162174
[float]
163175
[[features-8.16.0]]
164176
=== Features

‎docs/setup/upgrade/rollback-migration.asciidoc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ To roll back after a failed upgrade migration, you must also roll back the {kib}
2020
. To make sure no {kib} instances are performing an upgrade migration, shut down all {kib} instances.
2121
. {ref}/snapshots-restore-snapshot.html[Restore] the `kibana` feature state from a snapshot taken before the failed {kib} upgrade. The following {es} request will only restore the {kib} feature state
2222
+
23-
[source,sh]
23+
[source,console]
2424
--------------------------------------------
2525
POST _snapshot/my_repository/my_snapshot_2099.05.06/_restore
2626
{

‎docs/upgrade-notes.asciidoc‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -412,6 +412,15 @@ The endpoint is now split into two separate endpoints:
412412

413413
// General settings
414414

415+
[discrete]
416+
[[breaking-180986]]
417+
.[General settings] Updated request processing during shutdown. (8.16)
418+
[%collapsible]
419+
====
420+
*Details* +
421+
During shutdown, {kib} now waits for all the ongoing requests to complete according to the `server.shutdownTimeout` setting. During that period, the incoming socket is closed and any new incoming requests are rejected. Before this update, new incoming requests received a response with the status code 503 and body `{"message": "Kibana is shutting down and not accepting new incoming requests"}`. For more information, refer to {kibana-pull}180986[#180986].
422+
====
423+
415424
[discrete]
416425
[[breaking-111535]]
417426
.[General settings] Removed `CONFIG_PATH` and `DATA_PATH` environment variables. (8.0)

‎oas_docs/bundle.json‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1853,14 +1853,17 @@
18531853
},
18541854
"flapping": {
18551855
"additionalProperties": false,
1856+
"description": "When flapping detection is turned on, alerts that switch quickly between active and recovered states are identified as “flapping” and notifications are reduced.",
18561857
"nullable": true,
18571858
"properties": {
18581859
"look_back_window": {
1860+
"description": "The minimum number of runs in which the threshold must be met.",
18591861
"maximum": 20,
18601862
"minimum": 2,
18611863
"type": "number"
18621864
},
18631865
"status_change_threshold": {
1866+
"description": "The minimum number of times an alert must switch states in the look back window.",
18641867
"maximum": 20,
18651868
"minimum": 2,
18661869
"type": "number"
@@ -2690,14 +2693,17 @@
26902693
},
26912694
"flapping": {
26922695
"additionalProperties": false,
2696+
"description": "When flapping detection is turned on, alerts that switch quickly between active and recovered states are identified as “flapping” and notifications are reduced.",
26932697
"nullable": true,
26942698
"properties": {
26952699
"look_back_window": {
2700+
"description": "The minimum number of runs in which the threshold must be met.",
26962701
"maximum": 20,
26972702
"minimum": 2,
26982703
"type": "number"
26992704
},
27002705
"status_change_threshold": {
2706+
"description": "The minimum number of times an alert must switch states in the look back window.",
27012707
"maximum": 20,
27022708
"minimum": 2,
27032709
"type": "number"
@@ -3091,14 +3097,17 @@
30913097
},
30923098
"flapping": {
30933099
"additionalProperties": false,
3100+
"description": "When flapping detection is turned on, alerts that switch quickly between active and recovered states are identified as “flapping” and notifications are reduced.",
30943101
"nullable": true,
30953102
"properties": {
30963103
"look_back_window": {
3104+
"description": "The minimum number of runs in which the threshold must be met.",
30973105
"maximum": 20,
30983106
"minimum": 2,
30993107
"type": "number"
31003108
},
31013109
"status_change_threshold": {
3110+
"description": "The minimum number of times an alert must switch states in the look back window.",
31023111
"maximum": 20,
31033112
"minimum": 2,
31043113
"type": "number"
@@ -3918,14 +3927,17 @@
39183927
},
39193928
"flapping": {
39203929
"additionalProperties": false,
3930+
"description": "When flapping detection is turned on, alerts that switch quickly between active and recovered states are identified as “flapping” and notifications are reduced.",
39213931
"nullable": true,
39223932
"properties": {
39233933
"look_back_window": {
3934+
"description": "The minimum number of runs in which the threshold must be met.",
39243935
"maximum": 20,
39253936
"minimum": 2,
39263937
"type": "number"
39273938
},
39283939
"status_change_threshold": {
3940+
"description": "The minimum number of times an alert must switch states in the look back window.",
39293941
"maximum": 20,
39303942
"minimum": 2,
39313943
"type": "number"
@@ -4312,14 +4324,17 @@
43124324
},
43134325
"flapping": {
43144326
"additionalProperties": false,
4327+
"description": "When flapping detection is turned on, alerts that switch quickly between active and recovered states are identified as “flapping” and notifications are reduced.",
43154328
"nullable": true,
43164329
"properties": {
43174330
"look_back_window": {
4331+
"description": "The minimum number of runs in which the threshold must be met.",
43184332
"maximum": 20,
43194333
"minimum": 2,
43204334
"type": "number"
43214335
},
43224336
"status_change_threshold": {
4337+
"description": "The minimum number of times an alert must switch states in the look back window.",
43234338
"maximum": 20,
43244339
"minimum": 2,
43254340
"type": "number"
@@ -5817,14 +5832,17 @@
58175832
},
58185833
"flapping": {
58195834
"additionalProperties": false,
5835+
"description": "When flapping detection is turned on, alerts that switch quickly between active and recovered states are identified as “flapping” and notifications are reduced.",
58205836
"nullable": true,
58215837
"properties": {
58225838
"look_back_window": {
5839+
"description": "The minimum number of runs in which the threshold must be met.",
58235840
"maximum": 20,
58245841
"minimum": 2,
58255842
"type": "number"
58265843
},
58275844
"status_change_threshold": {
5845+
"description": "The minimum number of times an alert must switch states in the look back window.",
58285846
"maximum": 20,
58295847
"minimum": 2,
58305848
"type": "number"

‎oas_docs/output/kibana.yaml‎

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1652,14 +1652,24 @@ paths:
16521652
- last_execution_date
16531653
flapping:
16541654
additionalProperties: false
1655+
description: >-
1656+
When flapping detection is turned on, alerts that switch
1657+
quickly between active and recovered states are identified
1658+
as “flapping” and notifications are reduced.
16551659
nullable: true
16561660
type: object
16571661
properties:
16581662
look_back_window:
1663+
description: >-
1664+
The minimum number of runs in which the threshold must
1665+
be met.
16591666
maximum: 20
16601667
minimum: 2
16611668
type: number
16621669
status_change_threshold:
1670+
description: >-
1671+
The minimum number of times an alert must switch
1672+
states in the look back window.
16631673
maximum: 20
16641674
minimum: 2
16651675
type: number
@@ -2425,14 +2435,24 @@ paths:
24252435
type: boolean
24262436
flapping:
24272437
additionalProperties: false
2438+
description: >-
2439+
When flapping detection is turned on, alerts that switch
2440+
quickly between active and recovered states are identified
2441+
as “flapping” and notifications are reduced.
24282442
nullable: true
24292443
type: object
24302444
properties:
24312445
look_back_window:
2446+
description: >-
2447+
The minimum number of runs in which the threshold must
2448+
be met.
24322449
maximum: 20
24332450
minimum: 2
24342451
type: number
24352452
status_change_threshold:
2453+
description: >-
2454+
The minimum number of times an alert must switch states
2455+
in the look back window.
24362456
maximum: 20
24372457
minimum: 2
24382458
type: number
@@ -2825,14 +2845,24 @@ paths:
28252845
- last_execution_date
28262846
flapping:
28272847
additionalProperties: false
2848+
description: >-
2849+
When flapping detection is turned on, alerts that switch
2850+
quickly between active and recovered states are identified
2851+
as “flapping” and notifications are reduced.
28282852
nullable: true
28292853
type: object
28302854
properties:
28312855
look_back_window:
2856+
description: >-
2857+
The minimum number of runs in which the threshold must
2858+
be met.
28322859
maximum: 20
28332860
minimum: 2
28342861
type: number
28352862
status_change_threshold:
2863+
description: >-
2864+
The minimum number of times an alert must switch
2865+
states in the look back window.
28362866
maximum: 20
28372867
minimum: 2
28382868
type: number
@@ -3577,14 +3607,24 @@ paths:
35773607
- active
35783608
flapping:
35793609
additionalProperties: false
3610+
description: >-
3611+
When flapping detection is turned on, alerts that switch
3612+
quickly between active and recovered states are identified
3613+
as “flapping” and notifications are reduced.
35803614
nullable: true
35813615
type: object
35823616
properties:
35833617
look_back_window:
3618+
description: >-
3619+
The minimum number of runs in which the threshold must
3620+
be met.
35843621
maximum: 20
35853622
minimum: 2
35863623
type: number
35873624
status_change_threshold:
3625+
description: >-
3626+
The minimum number of times an alert must switch states
3627+
in the look back window.
35883628
maximum: 20
35893629
minimum: 2
35903630
type: number
@@ -3969,14 +4009,24 @@ paths:
39694009
- last_execution_date
39704010
flapping:
39714011
additionalProperties: false
4012+
description: >-
4013+
When flapping detection is turned on, alerts that switch
4014+
quickly between active and recovered states are identified
4015+
as “flapping” and notifications are reduced.
39724016
nullable: true
39734017
type: object
39744018
properties:
39754019
look_back_window:
4020+
description: >-
4021+
The minimum number of runs in which the threshold must
4022+
be met.
39764023
maximum: 20
39774024
minimum: 2
39784025
type: number
39794026
status_change_threshold:
4027+
description: >-
4028+
The minimum number of times an alert must switch
4029+
states in the look back window.
39804030
maximum: 20
39814031
minimum: 2
39824032
type: number
@@ -5205,14 +5255,24 @@ paths:
52055255
- last_execution_date
52065256
flapping:
52075257
additionalProperties: false
5258+
description: >-
5259+
When flapping detection is turned on, alerts that switch
5260+
quickly between active and recovered states are identified
5261+
as “flapping” and notifications are reduced.
52085262
nullable: true
52095263
type: object
52105264
properties:
52115265
look_back_window:
5266+
description: >-
5267+
The minimum number of runs in which the threshold must
5268+
be met.
52125269
maximum: 20
52135270
minimum: 2
52145271
type: number
52155272
status_change_threshold:
5273+
description: >-
5274+
The minimum number of times an alert must switch
5275+
states in the look back window.
52165276
maximum: 20
52175277
minimum: 2
52185278
type: number

‎packages/core/saved-objects/core-saved-objects-import-export-server-internal/src/import/lib/validate_references.test.ts‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,4 +267,36 @@ describe('validateReferences()', () => {
267267
'Error fetching references for imported objects'
268268
);
269269
});
270+
271+
// test that when references are missing returns only deduplicated errors
272+
test('returns only deduplicated errors when references are missing', async () => {
273+
const params = setup({
274+
objects: [
275+
{
276+
id: '2',
277+
type: 'visualization',
278+
attributes: { title: 'My Visualization 2' },
279+
references: [
280+
{ name: 'ref_0', type: 'index-pattern', id: '3' },
281+
{ name: 'ref_0', type: 'index-pattern', id: '3' },
282+
],
283+
},
284+
],
285+
});
286+
params.savedObjectsClient.bulkGet.mockResolvedValue({
287+
saved_objects: [createNotFoundError({ type: 'index-pattern', id: '3' })],
288+
});
289+
290+
const result = await validateReferences(params);
291+
expect(result).toEqual([
292+
expect.objectContaining({
293+
type: 'visualization',
294+
id: '2',
295+
error: {
296+
type: 'missing_references',
297+
references: [{ type: 'index-pattern', id: '3' }],
298+
},
299+
}),
300+
]);
301+
});
270302
});

0 commit comments

Comments
 (0)