adding implementsRenderComplete property to vis

ppisljar · ppisljar · commit b2ff87477cb2 · 2016-11-16T07:50:19.000+01:00
diff --git a/src/core_plugins/markdown_vis/public/markdown_vis.js b/src/core_plugins/markdown_vis/public/markdown_vis.js
@@ -24,7 +24,8 @@ function MarkdownVisProvider(Private) {
     params: {
       editor: markdownVisParamsTemplate
     },
-    requiresSearch: false
+    requiresSearch: false,
+    implementsRenderComplete: true,
   });
 }
 
diff --git a/src/core_plugins/metric_vis/public/metric_vis.js b/src/core_plugins/metric_vis/public/metric_vis.js
@@ -31,6 +31,7 @@ function MetricVisProvider(Private) {
       },
       editor: metricVisParamsTemplate
     },
+    implementsRenderComplete: true,
     schemas: new Schemas([
       {
         group: 'metrics',
diff --git a/src/core_plugins/table_vis/public/table_vis.js b/src/core_plugins/table_vis/public/table_vis.js
@@ -48,6 +48,7 @@ function TableVisTypeProvider(Private) {
       },
       editor: '<table-vis-params></table-vis-params>'
     },
+    implementsRenderComplete: true,
     hierarchicalData: function (vis) {
       return Boolean(vis.params.showPartialRows || vis.params.showMeticsAtAllLevels);
     },
diff --git a/src/core_plugins/timelion/public/vis/index.js b/src/core_plugins/timelion/public/vis/index.js
@@ -24,7 +24,8 @@ define(function (require) {
       params: {
         editor: require('plugins/timelion/vis/timelion_vis_params.html')
       },
-      requiresSearch: false
+      requiresSearch: false,
+      implementsRenderComplete: true,
     });
   }
 
diff --git a/src/ui/public/vis/vis_type.js b/src/ui/public/vis/vis_type.js
@@ -15,6 +15,7 @@ export default function VisTypeFactory(Private) {
     this.schemas = opts.schemas || new VisTypeSchemas();
     this.params = opts.params || {};
     this.requiresSearch = opts.requiresSearch == null ? true : opts.requiresSearch; // Default to true unless otherwise specified
+    this.implementsRenderComplete = false;
   }
 
   VisType.prototype.createRenderbot = function (vis, $el, uiState) {
diff --git a/src/ui/public/vislib_vis_type/vislib_vis_type.js b/src/ui/public/vislib_vis_type/vislib_vis_type.js
@@ -26,6 +26,7 @@ export default function VislibVisTypeFactory(Private) {
     }
 
     this.listeners = opts.listeners || {};
+    this.implementsRenderComplete = true;
   }
 
   VislibVisType.prototype.createRenderbot = function (vis, $el, uiState) {
diff --git a/src/ui/public/visualize/visualize.js b/src/ui/public/visualize/visualize.js
@@ -145,9 +145,6 @@ uiModules
 
         if (oldVis) $scope.renderbot = null;
         if (vis) {
-          vis.on('renderComplete', () => {
-            $scope.$emit('renderComplete');
-          });
           $scope.renderbot = vis.type.createRenderbot(vis, $visEl, $scope.uiState);
         }
       }));
@@ -169,7 +166,7 @@ uiModules
         }).catch(notify.fatal);
 
         searchSource.onError(e => {
-          $scope.$emit('renderComplete');
+          $scope.vis.emit('renderComplete');
           if (isTermSizeZeroError(e)) {
             return notify.error(
               `Your visualization ('${$scope.vis.title}') has an error: it has a term ` +

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,8 @@ function MarkdownVisProvider(Private) {`
`24`	`24`	`params: {`
`25`	`25`	`editor: markdownVisParamsTemplate`
`26`	`26`	`},`
`27`		`- requiresSearch: false`
	`27`	`+ requiresSearch: false,`
	`28`	`+ implementsRenderComplete: true,`
`28`	`29`	`});`
`29`	`30`	`}`
`30`	`31`
Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ function MetricVisProvider(Private) {`
`31`	`31`	`},`
`32`	`32`	`editor: metricVisParamsTemplate`
`33`	`33`	`},`
	`34`	`+ implementsRenderComplete: true,`
`34`	`35`	`schemas: new Schemas([`
`35`	`36`	`{`
`36`	`37`	`group: 'metrics',`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,8 @@ define(function (require) {`
`24`	`24`	`params: {`
`25`	`25`	`editor: require('plugins/timelion/vis/timelion_vis_params.html')`
`26`	`26`	`},`
`27`		`- requiresSearch: false`
	`27`	`+ requiresSearch: false,`
	`28`	`+ implementsRenderComplete: true,`
`28`	`29`	`});`
`29`	`30`	`}`
`30`	`31`
Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@ export default function VisTypeFactory(Private) {`
`15`	`15`	`this.schemas = opts.schemas \|\| new VisTypeSchemas();`
`16`	`16`	`this.params = opts.params \|\| {};`
`17`	`17`	`this.requiresSearch = opts.requiresSearch == null ? true : opts.requiresSearch; // Default to true unless otherwise specified`
	`18`	`+ this.implementsRenderComplete = false;`
`18`	`19`	`}`
`19`	`20`
`20`	`21`	`VisType.prototype.createRenderbot = function (vis, $el, uiState) {`
Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@ export default function VislibVisTypeFactory(Private) {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`this.listeners = opts.listeners \|\| {};`
	`29`	`+ this.implementsRenderComplete = true;`
`29`	`30`	`}`
`30`	`31`
`31`	`32`	`VislibVisType.prototype.createRenderbot = function (vis, $el, uiState) {`