chore(security, tests): log a warning in tests if deprecated feature privilege is replaced with more privileges than necessary

azasypkin · azasypkin · commit b24cc44d72e2 · 2025-07-03T21:00:10.000+03:00
diff --git a/x-pack/test/security_api_integration/tests/features/deprecated_features.ts b/x-pack/test/security_api_integration/tests/features/deprecated_features.ts
@@ -316,13 +316,25 @@ export default function ({ getService }: FtrProviderContext) {
           for (const deprecatedAction of deprecatedActions) {
             if (
               isReplaceableAction(deprecatedAction) &&
-              !replacementActions.has(deprecatedAction)
+              !replacementActions.delete(deprecatedAction)
             ) {
               throw new Error(
                 `Action "${deprecatedAction}" granted by the privilege "${privilegeId}" of the deprecated feature "${feature.id}" is not properly replaced.`
               );
             }
           }
+
+          const extraReplacementActions =
+            Array.from(replacementActions).filter(isReplaceableAction);
+          if (extraReplacementActions.length > 0) {
+            log.warning(
+              `Replacement actions for the privilege "${privilegeId}" of the deprecated feature "${
+                feature.id
+              }" grant more privileges than they were granting before: ${JSON.stringify(
+                extraReplacementActions
+              )} via ${JSON.stringify(replacedBy)}.`
+            );
+          }
         }
       }
     });
