Set inspector in plugin start method not external function

Aaron Caldwell · Aaron Caldwell · commit b07589b76a25 · 2020-03-18T15:19:51.000-06:00
diff --git a/x-pack/legacy/plugins/maps/public/plugin.ts b/x-pack/legacy/plugins/maps/public/plugin.ts
@@ -71,8 +71,7 @@ export const bindSetupCoreAndPlugins = (core: CoreSetup, plugins: any) => {
 };
 
 export const bindStartCoreAndPlugins = (core: CoreStart, plugins: any) => {
-  const { inspector, file_upload, data } = plugins;
-  setInspector(inspector);
+  const { file_upload, data } = plugins;
   setFileUpload(file_upload);
   setIndexPatternSelect(data.ui.IndexPatternSelect);
   setTimeFilter(data.query.timefilter.timefilter);
@@ -95,6 +94,7 @@ export class MapsPlugin implements Plugin<MapsPluginSetup, MapsPluginStart> {
   }
 
   public start(core: CoreStart, plugins: MapsPluginStartDependencies) {
+    setInspector(plugins.inspector);
     bindStartCoreAndPlugins(core, plugins);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -71,8 +71,7 @@ export const bindSetupCoreAndPlugins = (core: CoreSetup, plugins: any) => {`
`71`	`71`	`};`
`72`	`72`
`73`	`73`	`export const bindStartCoreAndPlugins = (core: CoreStart, plugins: any) => {`
`74`		`- const { inspector, file_upload, data } = plugins;`
`75`		`- setInspector(inspector);`
	`74`	`+ const { file_upload, data } = plugins;`
`76`	`75`	`setFileUpload(file_upload);`
`77`	`76`	`setIndexPatternSelect(data.ui.IndexPatternSelect);`
`78`	`77`	`setTimeFilter(data.query.timefilter.timefilter);`
`@@ -95,6 +94,7 @@ export class MapsPlugin implements Plugin<MapsPluginSetup, MapsPluginStart> {`
`95`	`94`	`}`
`96`	`95`
`97`	`96`	`public start(core: CoreStart, plugins: MapsPluginStartDependencies) {`
	`97`	`+ setInspector(plugins.inspector);`
`98`	`98`	`bindStartCoreAndPlugins(core, plugins);`
`99`	`99`	`}`
`100`	`100`	`}`