[ML] do not throw an error when agg is not supported by UI (#72685)

darnautov · peteharverson · commit ad91ba7df421 · 2020-07-22T09:36:12.000+01:00
diff --git a/x-pack/plugins/transform/public/app/common/pivot_aggs.test.ts b/x-pack/plugins/transform/public/app/common/pivot_aggs.test.ts
@@ -11,10 +11,6 @@ import {
 } from '../sections/create_transform/components/step_define/common/filter_agg/components';
 
 describe('getAggConfigFromEsAgg', () => {
-  test('should throw an error for unsupported agg', () => {
-    expect(() => getAggConfigFromEsAgg({ terms: {} }, 'test')).toThrowError();
-  });
-
   test('should return a common config if the agg does not have a custom config defined', () => {
     expect(getAggConfigFromEsAgg({ avg: { field: 'region' } }, 'test_1')).toEqual({
       agg: 'avg',
diff --git a/x-pack/plugins/transform/public/app/common/pivot_aggs.ts b/x-pack/plugins/transform/public/app/common/pivot_aggs.ts
@@ -110,8 +110,8 @@ export function getAggConfigFromEsAgg(
   // Find the main aggregation key
   const agg = aggKeys.find((aggKey) => aggKey !== 'aggs');
 
-  if (!isPivotSupportedAggs(agg)) {
-    throw new Error(`Aggregation "${agg}" is not supported`);
+  if (agg === undefined) {
+    throw new Error(`Aggregation key is required`);
   }
 
   const commonConfig: PivotAggsConfigBase = {

Original file line number	Diff line number	Diff line change
`@@ -110,8 +110,8 @@ export function getAggConfigFromEsAgg(`
`110`	`110`	`// Find the main aggregation key`
`111`	`111`	`const agg = aggKeys.find((aggKey) => aggKey !== 'aggs');`
`112`	`112`
`113`		`- if (!isPivotSupportedAggs(agg)) {`
`114`		- throw new Error(`Aggregation "${agg}" is not supported`);
	`113`	`+ if (agg === undefined) {`
	`114`	+ throw new Error(`Aggregation key is required`);
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`const commonConfig: PivotAggsConfigBase = {`