Skip to content

Commit aaa9604

Browse files
ek-sokibanamachineelasticmachine
authored
Small UI fixes for new Space creation/settings page (#197303)
## Summary [According to this PRD](https://docs.google.com/document/d/1HC_YjDtIzRvweU-oy6K2DevKfSvwfdHHZbjLFA43xls/edit#heading=h.jf3bwdwv0goe). * Solution selection inside space settings is now full width (point 7) * "Solution view" in features visibility section is not bold anymore (point 8) * Slightly tweaked placement for header and badges (point 14) ![CleanShot 2024-10-22 at 18 47 34@2x](https://github.com/user-attachments/assets/831772e4-e342-4999-baa4-79ec7341ffa9) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
1 parent 7dd66b3 commit aaa9604

4 files changed

Lines changed: 13 additions & 16 deletions

File tree

x-pack/plugins/spaces/public/management/components/enabled_features/__snapshots__/enabled_features.test.tsx.snap

Lines changed: 4 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugins/spaces/public/management/components/enabled_features/enabled_features.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,10 @@ export const EnabledFeatures: FunctionComponent<Props> = (props) => {
4343
defaultMessage="Choose the features to display in the navigation menu for users of this space. If you want to focus on a single solution, you can simplify the navigation even more by selecting a {solutionView}."
4444
values={{
4545
solutionView: (
46-
<strong>
47-
<FormattedMessage
48-
id="xpack.spaces.management.enabledSpaceFeatures.chooseFeaturesToDisplaySolutionViewText"
49-
defaultMessage="Solution view"
50-
/>
51-
</strong>
46+
<FormattedMessage
47+
id="xpack.spaces.management.enabledSpaceFeatures.chooseFeaturesToDisplaySolutionViewText"
48+
defaultMessage="Solution view"
49+
/>
5250
),
5351
}}
5452
/>

x-pack/plugins/spaces/public/management/components/solution_view/solution_view.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ export const SolutionView: FunctionComponent<Props> = ({
111111

112112
return (
113113
<SectionPanel title={sectionTitle} dataTestSubj="navigationPanel">
114-
<EuiFlexGroup alignItems="flexStart">
114+
<EuiFlexGroup alignItems="baseline">
115115
<EuiFlexItem>
116116
<EuiTitle size="xs">
117117
<EuiFlexGroup gutterSize="s">
@@ -163,6 +163,7 @@ export const SolutionView: FunctionComponent<Props> = ({
163163
onChange={(solution) => {
164164
onChange({ ...space, solution });
165165
}}
166+
fullWidth={true}
166167
placeholder={i18n.translate(
167168
'xpack.spaces.management.navigation.solutionViewDefaultValue',
168169
{ defaultMessage: 'Select solution view' }
@@ -180,7 +181,7 @@ export const SolutionView: FunctionComponent<Props> = ({
180181
/>
181182
</EuiText>
182183

183-
<EuiSpacer />
184+
<EuiSpacer size="m" />
184185
<EuiCallOut
185186
color="primary"
186187
size="s"

x-pack/plugins/spaces/public/management/edit_space/edit_space.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ export const EditSpace: FC<PageProps> = ({
212212
>
213213
<EuiFlexItem grow={true} css={{ flexBasis: '100%', width: '100%' }}>
214214
<EuiFlexGroup>
215-
<EuiFlexItem grow={false}>
215+
<EuiFlexItem grow={false} css={{ marginTop: '4px' }}>
216216
<HeaderAvatar />
217217
</EuiFlexItem>
218218
<EuiFlexItem grow={true}>
@@ -246,7 +246,7 @@ export const EditSpace: FC<PageProps> = ({
246246
</EuiFlexItem>
247247
</EuiFlexGroup>
248248
</EuiFlexItem>
249-
<EuiFlexItem grow={false}>
249+
<EuiFlexItem grow={false} css={{ marginTop: '4px' }}>
250250
<div>
251251
{shouldShowSolutionBadge ? (
252252
<SpaceSolutionBadge

0 commit comments

Comments
 (0)