Skip to content

Commit a4b65ac

Browse files
Fix flaky test saved objects tagging (#250891)
## Summary This PR fixes [Failing test: X-Pack Saved Object Tagging Functional Tests](#234592) issue. (More details in the description.)
1 parent 6c426b4 commit a4b65ac

2 files changed

Lines changed: 4 additions & 9 deletions

File tree

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2464,6 +2464,7 @@ x-pack/platform/test/functional/page_objects/search_profiler_page.ts @elastic/se
24642464
/x-pack/platform/test/serverless/functional/test_suites/spaces/spaces_management.ts @elastic/kibana-management
24652465
/x-pack/platform/test/stack_functional_integration/apps/management @elastic/kibana-management
24662466
/x-pack/platform/test/functional/page_objects/*_management_page.ts @elastic/kibana-management
2467+
/x-pack/platform/test/functional/page_objects/tag_management_page.ts @elastic/appex-sharedux
24672468
/src/platform/test/functional/services/saved_query_management_component.ts @elastic/kibana-management
24682469
/src/platform/test/functional/services/management @elastic/kibana-management
24692470
/x-pack/platform/test/functional/apps/cross_cluster_replication @elastic/kibana-management

x-pack/platform/test/functional/page_objects/tag_management_page.ts

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -470,17 +470,11 @@ export class TagManagementPageObject extends FtrService {
470470
if (!(await this.isActionMenuButtonDisplayed())) {
471471
return false;
472472
}
473-
const menuWasOpened = await this.isActionMenuOpened();
474-
if (!menuWasOpened) {
473+
if (!(await this.isActionMenuOpened())) {
475474
await this.openActionMenu();
476475
}
477476

478-
if (!menuWasOpened) {
479-
await this.toggleActionMenu();
480-
}
481-
482-
const actionExists = await this.testSubjects.exists(`actionBar-button-${actionId}`);
483-
return actionExists;
477+
return await this.testSubjects.exists(`actionBar-button-${actionId}`);
484478
}
485479

486480
/**
@@ -502,7 +496,7 @@ export class TagManagementPageObject extends FtrService {
502496
* Return true if the bulk action menu is opened, false otherwise.
503497
*/
504498
async isActionMenuOpened() {
505-
return this.testSubjects.exists('actionBar-contextMenuPopover');
499+
return this.testSubjects.exists('actionBar-contextMenu');
506500
}
507501

508502
/**

0 commit comments

Comments
 (0)