ensure values show correctly on edit

alvarezmelissa87 · alvarezmelissa87 · commit a47f4c4bd5e9 · 2025-06-25T17:29:23.000-06:00
diff --git a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/inference_flyout_wrapper.tsx b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/inference_flyout_wrapper.tsx
@@ -27,6 +27,33 @@ import type { InferenceEndpoint } from '../types/types';
 import { InferenceServiceFormFields } from './inference_service_form_fields';
 import { useInferenceEndpointMutation } from '../hooks/use_inference_endpoint_mutation';
 
+const formDeserializer = (data: InferenceEndpoint) => {
+  if (
+    data?.config?.providerConfig &&
+    data?.config?.providerConfig['adaptive_allocations.max_number_of_allocations']
+  ) {
+    // remove num_allocations and num_threads from the data as form does not expect it
+    const {
+      num_allocations: numAllocations,
+      num_threads: numThreads,
+      ...restOfProviderConfig
+    } = data.config.providerConfig;
+    return {
+      ...data,
+      config: {
+        ...data.config,
+        providerConfig: {
+          ...restOfProviderConfig,
+          max_number_of_allocations:
+            restOfProviderConfig['adaptive_allocations.max_number_of_allocations'],
+        },
+      },
+    };
+  }
+
+  return data;
+};
+
 interface InferenceFlyoutWrapperProps {
   onFlyoutClose: () => void;
   http: HttpSetup;
@@ -70,6 +97,7 @@ export const InferenceFlyoutWrapper: React.FC<InferenceFlyoutWrapperProps> = ({
         providerSecrets: {},
       },
     },
+    deserializer: formDeserializer,
   });
   const handleSubmit = useCallback(async () => {
     const { isValid, data } = await form.submit();
diff --git a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/constants.ts b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/constants.ts
@@ -59,7 +59,7 @@ export const INTERNAL_OVERRIDE_FIELDS: InternalOverrideFieldsType = {
           sensitive: false,
           supported_task_types: ['text_embedding', 'sparse_embedding', 'rerank'],
           type: FieldType.INTEGER,
-          updatable: true,
+          updatable: false,
         },
       },
     ],
diff --git a/x-pack/platform/plugins/shared/triggers_actions_ui/public/application/sections/action_connector_form/connector_form.tsx b/x-pack/platform/plugins/shared/triggers_actions_ui/public/application/sections/action_connector_form/connector_form.tsx
@@ -48,6 +48,11 @@ interface Props {
   onFormModifiedChange?: (isModified: boolean) => void;
   setResetForm?: (value: ResetForm) => void;
 }
+
+interface ProviderConfig {
+  [key: string]: unknown;
+  adaptive_allocations?: { max_number_of_allocations?: number };
+}
 /**
  * The serializer and deserializer are needed to transform the headers of
  * the webhook connectors. The webhook connector uses the UseArray component
@@ -62,6 +67,27 @@ interface Props {
 
 // TODO: Remove when https://github.com/elastic/kibana/issues/133107 is resolved
 const formDeserializer = (data: ConnectorFormSchema): ConnectorFormSchema => {
+  if (
+    data.actionTypeId === '.inference' &&
+    // explicit check to see if this field exists
+    (data?.config?.providerConfig as ProviderConfig)?.adaptive_allocations
+      ?.max_number_of_allocations
+  ) {
+    return {
+      ...data,
+      config: {
+        ...data.config,
+        providerConfig: {
+          ...(data.config.providerConfig as ProviderConfig),
+          max_number_of_allocations: (data.config.providerConfig as ProviderConfig)
+            .adaptive_allocations?.max_number_of_allocations,
+          // remove the adaptive_allocations from the data config as form does not expect it
+          adaptive_allocations: undefined,
+        },
+      },
+    };
+  }
+
   if (
     data.actionTypeId !== '.webhook' &&
     data.actionTypeId !== '.cases-webhook' &&
