[ResponseOps][Alerting] xpack.actions.proxyUrl is not validated as a URL at startup (#141970)

doakalexi · web-flow · commit a47918dcd9ca · 2022-09-28T10:17:50.000-07:00
* Adding validation

* Removing error
diff --git a/x-pack/plugins/actions/server/config.test.ts b/x-pack/plugins/actions/server/config.test.ts
@@ -163,6 +163,28 @@ describe('config validation', () => {
     `);
   });
 
+  test('validates proxyUrl', () => {
+    const proxyUrl = 'https://test.com';
+    const badProxyUrl = 'bad url';
+    let validated: ActionsConfig;
+
+    validated = configSchema.validate({ proxyUrl });
+    expect(validated.proxyUrl).toEqual(proxyUrl);
+    expect(getValidatedConfig(mockLogger, validated).proxyUrl).toEqual(proxyUrl);
+    expect(mockLogger.warn.mock.calls).toMatchInlineSnapshot(`Array []`);
+
+    validated = configSchema.validate({ proxyUrl: badProxyUrl });
+    expect(validated.proxyUrl).toEqual(badProxyUrl);
+    expect(getValidatedConfig(mockLogger, validated).proxyUrl).toEqual(badProxyUrl);
+    expect(mockLogger.warn.mock.calls).toMatchInlineSnapshot(`
+      Array [
+        Array [
+          "The confguration xpack.actions.proxyUrl: bad url is invalid.",
+        ],
+      ]
+    `);
+  });
+
   // Most of the customHostSettings tests are in ./lib/custom_host_settings.test.ts
   // but this one seemed more relevant for this test suite, since url is the one
   // required property.
diff --git a/x-pack/plugins/actions/server/config.ts b/x-pack/plugins/actions/server/config.ts
@@ -127,6 +127,15 @@ export type ActionsConfig = TypeOf<typeof configSchema>;
 export function getValidatedConfig(logger: Logger, originalConfig: ActionsConfig): ActionsConfig {
   const proxyBypassHosts = originalConfig.proxyBypassHosts;
   const proxyOnlyHosts = originalConfig.proxyOnlyHosts;
+  const proxyUrl = originalConfig.proxyUrl;
+
+  if (proxyUrl) {
+    try {
+      new URL(proxyUrl);
+    } catch (err) {
+      logger.warn(`The confguration xpack.actions.proxyUrl: ${proxyUrl} is invalid.`);
+    }
+  }
 
   if (proxyBypassHosts && proxyOnlyHosts) {
     logger.warn(
