Downgrade "setting up plugin" log to debug (#58776)

joshdover · joshdover · commit a3b060565867 · 2020-03-02T13:20:52.000-07:00
diff --git a/packages/kbn-plugin-generator/integration_tests/generate_plugin.test.js b/packages/kbn-plugin-generator/integration_tests/generate_plugin.test.js
@@ -102,6 +102,7 @@ describe(`running the plugin-generator via 'node scripts/generate_plugin.js plug
             'start',
             '--optimize.enabled=false',
             '--logging.json=false',
+            '--logging.verbose=true',
             '--migrations.skip=true',
           ],
           cwd: generatedPath,
diff --git a/src/core/server/plugins/plugin.ts b/src/core/server/plugins/plugin.ts
@@ -95,7 +95,7 @@ export class PluginWrapper<
   public async setup(setupContext: CoreSetup<TPluginsStart>, plugins: TPluginsSetup) {
     this.instance = this.createPluginInstance();
 
-    this.log.info('Setting up plugin');
+    this.log.debug('Setting up plugin');
 
     return this.instance.setup(setupContext, plugins);
   }
@@ -112,6 +112,8 @@ export class PluginWrapper<
       throw new Error(`Plugin "${this.name}" can't be started since it isn't set up.`);
     }
 
+    this.log.debug('Starting plugin');
+
     const startContract = await this.instance.start(startContext, plugins);
     this.startDependencies$.next([startContext, plugins]);
     return startContract;

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ export class PluginWrapper<`
`95`	`95`	`public async setup(setupContext: CoreSetup<TPluginsStart>, plugins: TPluginsSetup) {`
`96`	`96`	`this.instance = this.createPluginInstance();`
`97`	`97`
`98`		`- this.log.info('Setting up plugin');`
	`98`	`+ this.log.debug('Setting up plugin');`
`99`	`99`
`100`	`100`	`return this.instance.setup(setupContext, plugins);`
`101`	`101`	`}`
`@@ -112,6 +112,8 @@ export class PluginWrapper<`
`112`	`112`	throw new Error(`Plugin "${this.name}" can't be started since it isn't set up.`);
`113`	`113`	`}`
`114`	`114`
	`115`	`+ this.log.debug('Starting plugin');`
	`116`	`+`
`115`	`117`	`const startContract = await this.instance.start(startContext, plugins);`
`116`	`118`	`this.startDependencies$.next([startContext, plugins]);`
`117`	`119`	`return startContract;`