Fix validation

VladLasitsa · VladLasitsa · commit a328328aae40 · 2022-08-18T13:31:07.000+03:00
diff --git a/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/metrics/supported_metrics.ts b/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/metrics/supported_metrics.ts
@@ -85,28 +85,28 @@ export const SUPPORTED_METRICS: { [key: string]: AggOptions } = {
     name: 'overall_average',
     isFullReference: true,
     isFieldRequired: true,
-    supportedPanelTypes: [PANEL_TYPES.TIMESERIES, PANEL_TYPES.TOP_N],
+    supportedPanelTypes: [PANEL_TYPES.TIMESERIES],
     supportedTimeRangeModes: [TIME_RANGE_DATA_MODES.ENTIRE_TIME_RANGE],
   },
   max_bucket: {
     name: 'overall_max',
     isFullReference: true,
     isFieldRequired: true,
-    supportedPanelTypes: [PANEL_TYPES.TIMESERIES, PANEL_TYPES.TOP_N],
+    supportedPanelTypes: [PANEL_TYPES.TIMESERIES],
     supportedTimeRangeModes: [TIME_RANGE_DATA_MODES.ENTIRE_TIME_RANGE],
   },
   min_bucket: {
     name: 'overall_min',
     isFullReference: true,
     isFieldRequired: true,
-    supportedPanelTypes: [PANEL_TYPES.TIMESERIES, PANEL_TYPES.TOP_N],
+    supportedPanelTypes: [PANEL_TYPES.TIMESERIES],
     supportedTimeRangeModes: [TIME_RANGE_DATA_MODES.ENTIRE_TIME_RANGE],
   },
   sum_bucket: {
     name: 'overall_sum',
     isFullReference: true,
     isFieldRequired: true,
-    supportedPanelTypes: [PANEL_TYPES.TIMESERIES, PANEL_TYPES.TOP_N],
+    supportedPanelTypes: [PANEL_TYPES.TIMESERIES],
     supportedTimeRangeModes: [TIME_RANGE_DATA_MODES.ENTIRE_TIME_RANGE],
   },
   max: {
diff --git a/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/metrics/validate_metrics.ts b/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/metrics/validate_metrics.ts
@@ -34,8 +34,7 @@ export const isValidMetrics = (metrics: Metric[], panelType: string, timeRangeMo
   return metrics.every((metric) => {
     const isMetricAggValid =
       metric.type !== 'filter_ratio' ||
-      (metric.metric_agg &&
-        isMetricValid(metric.metric_agg, panelType, metric.field, timeRangeMode));
+      isMetricValid(metric.metric_agg || 'count', panelType, metric.field, timeRangeMode);
     return (
       metric.type === 'series_agg' ||
       (isMetricValid(metric.type, panelType, metric.field, timeRangeMode) && isMetricAggValid)
