[CI] Add slack alerts to tracked branch jobs, change default channel, change formatting (#66580)

brianseeders · brianseeders · commit a11bb8edea59 · 2020-05-15T10:48:12.000-04:00
diff --git a/Jenkinsfile b/Jenkinsfile
@@ -53,7 +53,9 @@ kibanaPipeline(timeoutMinutes: 135, checkPrChanges: true) {
       }
     }
 
-    retryable.printFlakyFailures()
-    kibanaPipeline.sendMail()
+    if (params.NOTIFY_ON_FAILURE) {
+      slackNotifications.onFailure()
+      kibanaPipeline.sendMail()
+    }
   }
 }
diff --git a/vars/slackNotifications.groovy b/vars/slackNotifications.groovy
@@ -62,21 +62,32 @@ def getTestFailures() {
   def messages = []
   messages << "*Test Failures*"
 
-  def list = failures.collect { "• <${it.url}|${it.fullDisplayName}>" }.join("\n")
+  def list = failures.collect { "• <${it.url}|${it.fullDisplayName.split('.', 2)[-1]}>" }.join("\n")
   return "*Test Failures*\n${list}"
 }
 
-def sendFailedBuild(Map params = [:]) {
-  def displayName = "${env.JOB_NAME} ${env.BUILD_DISPLAY_NAME}"
+def getDefaultDisplayName() {
+  return "${env.JOB_NAME} ${env.BUILD_DISPLAY_NAME}"
+}
 
+def getDefaultContext() {
+  def duration = currentBuild.durationString.replace(' and counting', '')
+
+  return contextBlock([
+    "${buildUtils.getBuildStatus().toLowerCase().capitalize()} after ${duration}",
+    "<https://ci.kibana.dev/${env.JOB_BASE_NAME}/${env.BUILD_NUMBER}|ci.kibana.dev>",
+  ].join(' · '))
+}
+
+def sendFailedBuild(Map params = [:]) {
   def config = [
-    channel: '#kibana-operations',
-    title: ":broken_heart: *<${env.BUILD_URL}|${displayName}>*",
-    message: ":broken_heart: ${displayName}",
+    channel: '#kibana-operations-alerts',
+    title: ":broken_heart: *<${env.BUILD_URL}|${getDefaultDisplayName()}>*",
+    message: ":broken_heart: ${getDefaultDisplayName()}",
     color: 'danger',
     icon: ':jenkins:',
     username: 'Kibana Operations',
-    context: contextBlock("${displayName} · <https://ci.kibana.dev/${env.JOB_BASE_NAME}/${env.BUILD_NUMBER}|ci.kibana.dev>"),
+    context: getDefaultContext(),
   ] + params
 
   def blocks = [markdownBlock(config.title)]
@@ -94,18 +105,24 @@ def sendFailedBuild(Map params = [:]) {
   )
 }
 
+def onFailure(Map options = [:]) {
+  catchError {
+    def status = buildUtils.getBuildStatus()
+    if (status != "SUCCESS") {
+      catchErrors {
+        sendFailedBuild(options)
+      }
+    }
+  }
+}
+
 def onFailure(Map options = [:], Closure closure) {
   // try/finally will NOT work here, because the build status will not have been changed to ERROR when the finally{} block executes
   catchError {
     closure()
   }
 
-  def status = buildUtils.getBuildStatus()
-  if (status != "SUCCESS" && status != "UNSTABLE") {
-    catchErrors {
-      sendFailedBuild(options)
-    }
-  }
+  onFailure(options)
 }
 
 return this

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,9 @@ kibanaPipeline(timeoutMinutes: 135, checkPrChanges: true) {`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`
`56`		`- retryable.printFlakyFailures()`
`57`		`- kibanaPipeline.sendMail()`
	`56`	`+ if (params.NOTIFY_ON_FAILURE) {`
	`57`	`+ slackNotifications.onFailure()`
	`58`	`+ kibanaPipeline.sendMail()`
	`59`	`+ }`
`58`	`60`	`}`
`59`	`61`	`}`