Fix off-by-one in validation error row index

maxcold · maxcold · commit a0df17eac07c · 2026-03-29T12:42:47.000+02:00
Account for the header row when reporting CSV line numbers.
PapaParse with header:true excludes the header from data, so
data[0] is line 2 in the original file.
diff --git a/x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/entity_resolution_file_uploader/validations.ts b/x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/entity_resolution_file_uploader/validations.ts
@@ -112,7 +112,7 @@ export const validateParsedRows = (
     const error = validateRow(row);
     if (error) {
       invalid.push(row);
-      errors.push({ message: error, index: i + 1 }); // 1-based original CSV row number
+      errors.push({ message: error, index: i + 2 }); // +2: 1-based + skip header row
     } else {
       valid.push(row);
     }

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ export const validateParsedRows = (`
`112`	`112`	`const error = validateRow(row);`
`113`	`113`	`if (error) {`
`114`	`114`	`invalid.push(row);`
`115`		`- errors.push({ message: error, index: i + 1 }); // 1-based original CSV row number`
	`115`	`+ errors.push({ message: error, index: i + 2 }); // +2: 1-based + skip header row`
`116`	`116`	`} else {`
`117`	`117`	`valid.push(row);`
`118`	`118`	`}`