CR: add missing _bulk_edit route error handlers

vitaliidm · vitaliidm · commit 9faef0ba878b · 2022-05-11T12:45:10.000+01:00
diff --git a/x-pack/plugins/alerting/server/routes/bulk_edit_rules.test.ts b/x-pack/plugins/alerting/server/routes/bulk_edit_rules.test.ts
@@ -10,6 +10,7 @@ import { httpServiceMock } from '@kbn/core/server/mocks';
 import { bulkEditInternalRulesRoute } from './bulk_edit_rules';
 import { licenseStateMock } from '../lib/license_state.mock';
 import { verifyApiAccess } from '../lib/license_api_access';
+import { RuleTypeDisabledError } from '../lib/errors/rule_type_disabled';
 import { mockHandlerArguments } from './_mock_handler_arguments';
 import { rulesClientMock } from '../rules_client.mock';
 import { SanitizedRule } from '../types';
@@ -164,4 +165,24 @@ describe('bulkEditInternalRulesRoute', () => {
 
     expect(handler(context, req, res)).rejects.toMatchInlineSnapshot(`[Error: Failure]`);
   });
+
+  it('ensures the rule type gets validated for the license', async () => {
+    const licenseState = licenseStateMock.create();
+    const router = httpServiceMock.createRouter();
+
+    bulkEditInternalRulesRoute(router, licenseState);
+
+    const [, handler] = router.post.mock.calls[0];
+
+    rulesClient.bulkEdit.mockRejectedValue(new RuleTypeDisabledError('Fail', 'license_invalid'));
+
+    const [context, req, res] = mockHandlerArguments({ rulesClient }, { params: {}, body: {} }, [
+      'ok',
+      'forbidden',
+    ]);
+
+    await handler(context, req, res);
+
+    expect(res.forbidden).toHaveBeenCalledWith({ body: { message: 'Fail' } });
+  });
 });
diff --git a/x-pack/plugins/alerting/server/routes/bulk_edit_rules.ts b/x-pack/plugins/alerting/server/routes/bulk_edit_rules.ts
@@ -8,8 +8,8 @@
 import { schema } from '@kbn/config-schema';
 import { IRouter } from '@kbn/core/server';
 
-import { ILicenseState } from '../lib';
-import { verifyAccessAndContext, rewriteRule } from './lib';
+import { ILicenseState, RuleTypeDisabledError } from '../lib';
+import { verifyAccessAndContext, rewriteRule, handleDisabledApiKeysError } from './lib';
 import { AlertingRequestHandlerContext, INTERNAL_BASE_ALERTING_API_PATH } from '../types';
 
 const ruleActionSchema = schema.object({
@@ -58,20 +58,29 @@ const buildBulkEditRulesRoute = ({ licenseState, path, router }: BuildBulkEditRu
         body: bodySchema,
       },
     },
-    router.handleLegacyErrors(
-      verifyAccessAndContext(licenseState, async function (context, req, res) {
-        const rulesClient = (await context.alerting).getRulesClient();
-        const { filter, operations, ids } = req.body;
+    handleDisabledApiKeysError(
+      router.handleLegacyErrors(
+        verifyAccessAndContext(licenseState, async function (context, req, res) {
+          const rulesClient = (await context.alerting).getRulesClient();
+          const { filter, operations, ids } = req.body;
 
-        const bulkEditResults = await rulesClient.bulkEdit({
-          filter,
-          ids: ids as string[],
-          operations,
-        });
-        return res.ok({
-          body: { ...bulkEditResults, rules: bulkEditResults.rules.map(rewriteRule) },
-        });
-      })
+          try {
+            const bulkEditResults = await rulesClient.bulkEdit({
+              filter,
+              ids: ids as string[],
+              operations,
+            });
+            return res.ok({
+              body: { ...bulkEditResults, rules: bulkEditResults.rules.map(rewriteRule) },
+            });
+          } catch (e) {
+            if (e instanceof RuleTypeDisabledError) {
+              return e.sendResponse(res);
+            }
+            throw e;
+          }
+        })
+      )
     )
   );
 };
