Fixing generator start and end time generation

jonathan-buttner · jonathan-buttner · commit 9e9abf68a661 · 2020-11-18T13:59:32.000-05:00
diff --git a/x-pack/plugins/security_solution/common/endpoint/generate_data.test.ts b/x-pack/plugins/security_solution/common/endpoint/generate_data.test.ts
@@ -272,16 +272,14 @@ describe('data generator', () => {
       let startTime = new Date(timestampSafeVersion(tree.allEvents[0]) ?? startOfEpoch);
       expect(startTime).not.toEqual(startOfEpoch);
       let endTime = new Date(timestampSafeVersion(tree.allEvents[0]) ?? startOfEpoch);
-      expect(startTime).not.toEqual(startOfEpoch);
+      expect(endTime).not.toEqual(startOfEpoch);
 
       for (const event of tree.allEvents) {
         const currentEventTime = new Date(timestampSafeVersion(event) ?? startOfEpoch);
         expect(currentEventTime).not.toEqual(startOfEpoch);
         if (currentEventTime < startTime) {
           startTime = currentEventTime;
-        }
-
-        if (currentEventTime > endTime) {
+        } else {
           endTime = currentEventTime;
         }
       }
diff --git a/x-pack/plugins/security_solution/common/endpoint/generate_data.ts b/x-pack/plugins/security_solution/common/endpoint/generate_data.ts
@@ -726,7 +726,7 @@ export class EndpointDocGenerator {
       if (eventTimestamp !== undefined) {
         if (eventTimestamp < startTime) {
           startTime = eventTimestamp;
-        } else if (eventTimestamp > endTime) {
+        } else {
           endTime = eventTimestamp;
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -726,7 +726,7 @@ export class EndpointDocGenerator {`
`726`	`726`	`if (eventTimestamp !== undefined) {`
`727`	`727`	`if (eventTimestamp < startTime) {`
`728`	`728`	`startTime = eventTimestamp;`
`729`		`- } else if (eventTimestamp > endTime) {`
	`729`	`+ } else {`
`730`	`730`	`endTime = eventTimestamp;`
`731`	`731`	`}`
`732`	`732`	`}`