test grouping only when sampling is not used.

walterra · walterra · commit 9af0759d4111 · 2023-04-25T16:13:22.000+02:00
diff --git a/x-pack/test/functional/apps/aiops/explain_log_rate_spikes.ts b/x-pack/test/functional/apps/aiops/explain_log_rate_spikes.ts
@@ -155,80 +155,80 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
       // The group switch should be disabled by default
       await aiops.explainLogRateSpikesPage.assertSpikeAnalysisGroupSwitchExists(false);
 
-      // Enabled grouping
-      await aiops.explainLogRateSpikesPage.clickSpikeAnalysisGroupSwitch(false);
+      if (!isTestDataExpectedWithSampleProbability(testData.expected)) {
+        // Enabled grouping
+        await aiops.explainLogRateSpikesPage.clickSpikeAnalysisGroupSwitch(false);
 
-      await aiops.explainLogRateSpikesAnalysisGroupsTable.assertSpikeAnalysisTableExists();
+        await aiops.explainLogRateSpikesAnalysisGroupsTable.assertSpikeAnalysisTableExists();
 
-      if (!isTestDataExpectedWithSampleProbability(testData.expected)) {
         const analysisGroupsTable =
           await aiops.explainLogRateSpikesAnalysisGroupsTable.parseAnalysisTable();
         expect(orderBy(analysisGroupsTable, 'group')).to.be.eql(
           orderBy(testData.expected.analysisGroupsTable, 'group')
         );
-      }
-
-      await ml.testExecution.logTestStep('expand table row');
-      await aiops.explainLogRateSpikesAnalysisGroupsTable.assertExpandRowButtonExists();
-      await aiops.explainLogRateSpikesAnalysisGroupsTable.expandRow();
-
-      if (!isTestDataExpectedWithSampleProbability(testData.expected)) {
-        const analysisTable = await aiops.explainLogRateSpikesAnalysisTable.parseAnalysisTable();
-        expect(orderBy(analysisTable, ['fieldName', 'fieldValue'])).to.be.eql(
-          orderBy(testData.expected.analysisTable, ['fieldName', 'fieldValue'])
-        );
-      }
-
-      await ml.testExecution.logTestStep('open the field filter');
-      await aiops.explainLogRateSpikesPage.assertFieldFilterPopoverButtonExists(false);
-      await aiops.explainLogRateSpikesPage.clickFieldFilterPopoverButton(true);
-      await aiops.explainLogRateSpikesPage.assertFieldSelectorFieldNameList(
-        testData.expected.fieldSelectorPopover
-      );
 
-      await ml.testExecution.logTestStep('filter fields');
-      await aiops.explainLogRateSpikesPage.setFieldSelectorSearch(testData.fieldSelectorSearch);
-      await aiops.explainLogRateSpikesPage.assertFieldSelectorFieldNameList([
-        testData.fieldSelectorSearch,
-      ]);
-      await aiops.explainLogRateSpikesPage.clickFieldSelectorDisableAllSelectedButton();
-      await aiops.explainLogRateSpikesPage.assertFieldFilterApplyButtonExists(
-        !testData.fieldSelectorApplyAvailable
-      );
-
-      if (testData.fieldSelectorApplyAvailable) {
-        await ml.testExecution.logTestStep('regroup results');
-        await aiops.explainLogRateSpikesPage.clickFieldFilterApplyButton();
+        await ml.testExecution.logTestStep('expand table row');
+        await aiops.explainLogRateSpikesAnalysisGroupsTable.assertExpandRowButtonExists();
+        await aiops.explainLogRateSpikesAnalysisGroupsTable.expandRow();
 
         if (!isTestDataExpectedWithSampleProbability(testData.expected)) {
-          const filteredAnalysisGroupsTable =
-            await aiops.explainLogRateSpikesAnalysisGroupsTable.parseAnalysisTable();
-          expect(orderBy(filteredAnalysisGroupsTable, 'group')).to.be.eql(
-            orderBy(testData.expected.filteredAnalysisGroupsTable, 'group')
+          const analysisTable = await aiops.explainLogRateSpikesAnalysisTable.parseAnalysisTable();
+          expect(orderBy(analysisTable, ['fieldName', 'fieldValue'])).to.be.eql(
+            orderBy(testData.expected.analysisTable, ['fieldName', 'fieldValue'])
           );
         }
-      }
 
-      if (testData.action !== undefined) {
-        await ml.testExecution.logTestStep('check all table row actions are present');
-        await aiops.explainLogRateSpikesAnalysisGroupsTable.assertRowActions(
-          testData.action.tableRowId
+        await ml.testExecution.logTestStep('open the field filter');
+        await aiops.explainLogRateSpikesPage.assertFieldFilterPopoverButtonExists(false);
+        await aiops.explainLogRateSpikesPage.clickFieldFilterPopoverButton(true);
+        await aiops.explainLogRateSpikesPage.assertFieldSelectorFieldNameList(
+          testData.expected.fieldSelectorPopover
         );
 
-        await ml.testExecution.logTestStep('click log pattern analysis action');
-        await aiops.explainLogRateSpikesAnalysisGroupsTable.clickRowAction(
-          testData.action.tableRowId,
-          testData.action.type
+        await ml.testExecution.logTestStep('filter fields');
+        await aiops.explainLogRateSpikesPage.setFieldSelectorSearch(testData.fieldSelectorSearch);
+        await aiops.explainLogRateSpikesPage.assertFieldSelectorFieldNameList([
+          testData.fieldSelectorSearch,
+        ]);
+        await aiops.explainLogRateSpikesPage.clickFieldSelectorDisableAllSelectedButton();
+        await aiops.explainLogRateSpikesPage.assertFieldFilterApplyButtonExists(
+          !testData.fieldSelectorApplyAvailable
         );
 
-        await ml.testExecution.logTestStep('check log pattern analysis page loaded correctly');
-        await aiops.logPatternAnalysisPageProvider.assertLogCategorizationPageExists();
-        await aiops.logPatternAnalysisPageProvider.assertTotalDocumentCount(
-          testData.action.expected.totalDocCount
-        );
-        await aiops.logPatternAnalysisPageProvider.assertQueryInput(
-          testData.action.expected.queryBar
-        );
+        if (testData.fieldSelectorApplyAvailable) {
+          await ml.testExecution.logTestStep('regroup results');
+          await aiops.explainLogRateSpikesPage.clickFieldFilterApplyButton();
+
+          if (!isTestDataExpectedWithSampleProbability(testData.expected)) {
+            const filteredAnalysisGroupsTable =
+              await aiops.explainLogRateSpikesAnalysisGroupsTable.parseAnalysisTable();
+            expect(orderBy(filteredAnalysisGroupsTable, 'group')).to.be.eql(
+              orderBy(testData.expected.filteredAnalysisGroupsTable, 'group')
+            );
+          }
+        }
+
+        if (testData.action !== undefined) {
+          await ml.testExecution.logTestStep('check all table row actions are present');
+          await aiops.explainLogRateSpikesAnalysisGroupsTable.assertRowActions(
+            testData.action.tableRowId
+          );
+
+          await ml.testExecution.logTestStep('click log pattern analysis action');
+          await aiops.explainLogRateSpikesAnalysisGroupsTable.clickRowAction(
+            testData.action.tableRowId,
+            testData.action.type
+          );
+
+          await ml.testExecution.logTestStep('check log pattern analysis page loaded correctly');
+          await aiops.logPatternAnalysisPageProvider.assertLogCategorizationPageExists();
+          await aiops.logPatternAnalysisPageProvider.assertTotalDocumentCount(
+            testData.action.expected.totalDocCount
+          );
+          await aiops.logPatternAnalysisPageProvider.assertQueryInput(
+            testData.action.expected.queryBar
+          );
+        }
       }
     });
   }
