[ML] Fix classification feature importance object.

walterra · walterra · commit 96ccaef1be66 · 2020-10-29T17:50:41.000+01:00
diff --git a/x-pack/plugins/ml/public/application/components/data_grid/common.ts b/x-pack/plugins/ml/public/application/components/data_grid/common.ts
@@ -184,13 +184,17 @@ export const getFeatureImportance = (
 
   // return object structure for classification job
   if (classNames !== undefined && classImportance !== undefined) {
+    const overallClassNames = classNames?.slice(0, classNames.length / featureNames.length);
+
     return featureNames.map((fName, index) => {
-      const offset = featureNames.length * index;
-      const featureClassNames = classNames.slice(offset, offset + featureNames.length);
-      const featureClassImportance = classImportance.slice(offset, offset + featureNames.length);
+      const offset = overallClassNames.length * index;
+      const featureClassImportance = classImportance.slice(
+        offset,
+        offset + overallClassNames.length
+      );
       return {
         feature_name: fName,
-        classes: featureClassNames.map((fClassName, fIndex) => {
+        classes: overallClassNames.map((fClassName, fIndex) => {
           return { class_name: fClassName, importance: featureClassImportance[fIndex] };
         }),
       };
diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_exploration/components/exploration_results_table/exploration_results_table.tsx b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_exploration/components/exploration_results_table/exploration_results_table.tsx
@@ -29,7 +29,7 @@ interface Props {
 }
 
 export const ExplorationResultsTable: FC<Props> = React.memo(
-  ({ indexPattern, jobConfig, jobStatus, needsDestIndexPattern, searchQuery }) => {
+  ({ indexPattern, jobConfig, needsDestIndexPattern, searchQuery }) => {
     const {
       services: {
         mlServices: { mlApiServices },

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ interface Props {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`export const ExplorationResultsTable: FC<Props> = React.memo(`
`32`		`- ({ indexPattern, jobConfig, jobStatus, needsDestIndexPattern, searchQuery }) => {`
	`32`	`+ ({ indexPattern, jobConfig, needsDestIndexPattern, searchQuery }) => {`
`33`	`33`	`const {`
`34`	`34`	`services: {`
`35`	`35`	`mlServices: { mlApiServices },`