privilege check

darnautov · darnautov · commit 9372b2ab3359 · 2021-10-19T14:52:38.000+02:00
diff --git a/x-pack/plugins/transform/public/app/lib/authorization/components/authorization_provider.tsx b/x-pack/plugins/transform/public/app/lib/authorization/components/authorization_provider.tsx
@@ -20,12 +20,14 @@ interface Authorization {
   capabilities: Capabilities;
 }
 
-const initialCapabalities: Capabilities = {
+const initialCapabilities: Capabilities = {
   canGetTransform: false,
   canDeleteTransform: false,
   canPreviewTransform: false,
   canCreateTransform: false,
   canStartStopTransform: false,
+  canCreateTransformAlerts: false,
+  canUseTransformAlerts: false,
 };
 
 const initialValue: Authorization = {
@@ -35,7 +37,7 @@ const initialValue: Authorization = {
     hasAllPrivileges: false,
     missingPrivileges: {},
   },
-  capabilities: initialCapabalities,
+  capabilities: initialCapabilities,
 };
 
 export const AuthorizationContext = createContext<Authorization>({ ...initialValue });
@@ -58,7 +60,7 @@ export const AuthorizationProvider = ({ privilegesEndpoint, children }: Props) =
   const value = {
     isLoading,
     privileges: isLoading ? { ...initialValue.privileges } : privilegesData,
-    capabilities: { ...initialCapabalities },
+    capabilities: { ...initialCapabilities },
     apiError: error ? (error as Error) : null,
   };
 
@@ -85,6 +87,10 @@ export const AuthorizationProvider = ({ privilegesEndpoint, children }: Props) =
     hasPrivilege(['cluster', 'cluster:admin/transform/start_task']) &&
     hasPrivilege(['cluster', 'cluster:admin/transform/stop']);
 
+  value.capabilities.canCreateTransformAlerts = value.capabilities.canCreateTransform;
+
+  value.capabilities.canUseTransformAlerts = value.capabilities.canGetTransform;
+
   return (
     <AuthorizationContext.Provider value={{ ...value }}>{children}</AuthorizationContext.Provider>
   );
diff --git a/x-pack/plugins/transform/public/app/lib/authorization/components/common.ts b/x-pack/plugins/transform/public/app/lib/authorization/components/common.ts
@@ -16,6 +16,8 @@ export interface Capabilities {
   canPreviewTransform: boolean;
   canCreateTransform: boolean;
   canStartStopTransform: boolean;
+  canCreateTransformAlerts: boolean;
+  canUseTransformAlerts: boolean;
 }
 
 export type Privilege = [string, string];
@@ -67,6 +69,14 @@ export function createCapabilityFailureMessage(
         defaultMessage: 'You do not have permission to create transforms.',
       });
       break;
+    case 'canCreateTransformAlerts':
+      message = i18n.translate(
+        'xpack.transform.capability.noPermission.canCreateTransformAlertsTooltip',
+        {
+          defaultMessage: 'You do not have permission to create transform alert rules.',
+        }
+      );
+      break;
     case 'canStartStopTransform':
       message = i18n.translate(
         'xpack.transform.capability.noPermission.startOrStopTransformTooltip',
diff --git a/x-pack/plugins/transform/public/app/sections/transform_management/components/action_create_alert/create_alert_rule_action_name.tsx b/x-pack/plugins/transform/public/app/sections/transform_management/components/action_create_alert/create_alert_rule_action_name.tsx
@@ -25,7 +25,10 @@ export const crateAlertRuleActionNameText = i18n.translate(
 export const CreateAlertRuleActionName: FC<CreateAlertRuleActionProps> = ({ disabled }) => {
   if (disabled) {
     return (
-      <EuiToolTip position="top" content={createCapabilityFailureMessage('canStartStopTransform')}>
+      <EuiToolTip
+        position="top"
+        content={createCapabilityFailureMessage('canCreateTransformAlerts')}
+      >
         <>{crateAlertRuleActionNameText}</>
       </EuiToolTip>
     );
diff --git a/x-pack/plugins/transform/public/app/sections/transform_management/components/action_create_alert/use_create_alert_rule_action.tsx b/x-pack/plugins/transform/public/app/sections/transform_management/components/action_create_alert/use_create_alert_rule_action.tsx
@@ -17,7 +17,7 @@ import { isContinuousTransform } from '../../../../../../common/types/transform'
 
 export type CreateAlertRuleAction = ReturnType<typeof useCreateAlertRuleAction>;
 export const useCreateAlertRuleAction = (forceDisable: boolean) => {
-  const { canCreateTransform } = useContext(AuthorizationContext).capabilities;
+  const { canCreateTransformAlerts } = useContext(AuthorizationContext).capabilities;
   const { setCreateAlertRule } = useAlertRuleFlyout();
 
   const clickHandler = useCallback(
@@ -30,17 +30,17 @@ export const useCreateAlertRuleAction = (forceDisable: boolean) => {
   const action: TransformListAction = useMemo(
     () => ({
       name: (item: TransformListRow) => (
-        <CreateAlertRuleActionName disabled={!canCreateTransform} />
+        <CreateAlertRuleActionName disabled={!canCreateTransformAlerts} />
       ),
       available: (item: TransformListRow) => isContinuousTransform(item.config),
-      enabled: () => canCreateTransform && !forceDisable,
+      enabled: () => canCreateTransformAlerts && !forceDisable,
       description: crateAlertRuleActionNameText,
       type: 'icon',
       icon: 'bell',
       onClick: clickHandler,
       'data-test-subj': 'transformActionCreateAlertRule',
     }),
-    [canCreateTransform, forceDisable, clickHandler]
+    [canCreateTransformAlerts, forceDisable, clickHandler]
   );
 
   return { action };
diff --git a/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/use_actions.test.tsx b/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/use_actions.test.tsx
@@ -27,6 +27,7 @@ describe('Transform: Transform List Actions', () => {
     // in the runtime result here anyway.
     expect(actions.map((a: any) => a['data-test-subj'])).toStrictEqual([
       'transformActionDiscover',
+      'transformActionCreateAlertRule',
       'transformActionStart',
       'transformActionStop',
       'transformActionEdit',
