Skip to content

Commit 8fd9bdd

Browse files
kqualters-elastickqualters-elastic
committed
Add missing row renderer draggables to use top N props
1 parent 1eb3fe0 commit 8fd9bdd

19 files changed

Lines changed: 100 additions & 0 deletions

File tree

‎x-pack/plugins/security_solution/public/network/components/direction/index.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ export const DirectionBadge = React.memo<{
7070
iconType={getDirectionIcon(direction)}
7171
isDraggable={isDraggable}
7272
value={direction}
73+
isAggregatable={true}
74+
fieldType="keyword"
7375
/>
7476
));
7577

‎x-pack/plugins/security_solution/public/network/components/source_destination/network.tsx‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ export const Network = React.memo<{
8585
field={NETWORK_PROTOCOL_FIELD_NAME}
8686
isDraggable={isDraggable}
8787
value={proto}
88+
isAggregatable={true}
89+
fieldType="keyword"
8890
/>
8991
</EuiFlexItemMarginRight>
9092
))
@@ -138,6 +140,8 @@ export const Network = React.memo<{
138140
field={NETWORK_TRANSPORT_FIELD_NAME}
139141
isDraggable={isDraggable}
140142
value={trans}
143+
isAggregatable={true}
144+
fieldType="keyword"
141145
/>
142146
</EuiFlexItemMarginRight>
143147
))
@@ -153,6 +157,8 @@ export const Network = React.memo<{
153157
field={NETWORK_COMMUNITY_ID_FIELD_NAME}
154158
isDraggable={isDraggable}
155159
value={trans}
160+
isAggregatable={true}
161+
fieldType="keyword"
156162
/>
157163
</EuiFlexItem>
158164
))

‎x-pack/plugins/security_solution/public/timelines/components/certificate_fingerprint/index.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ export const CertificateFingerprint = React.memo<{
5757
</EuiText>
5858
}
5959
value={value}
60+
isAggregatable={true}
61+
fieldType="keyword"
6062
>
6163
<FingerprintLabel data-test-subj="fingerprint-label">
6264
{certificateType === 'client' ? i18n.CLIENT_CERT : i18n.SERVER_CERT}

‎x-pack/plugins/security_solution/public/timelines/components/ja3_fingerprint/index.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ export const Ja3Fingerprint = React.memo<{
4141
iconType="snowflake"
4242
isDraggable={isDraggable}
4343
value={value}
44+
isAggregatable={true}
45+
fieldType="keyword"
4446
>
4547
<Ja3FingerprintLabel data-test-subj="ja3-fingerprint-label">
4648
{i18n.JA3_FINGERPRINT_LABEL}

‎x-pack/plugins/security_solution/public/timelines/components/netflow/netflow_columns/user_process.tsx‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ export const UserProcess = React.memo<{
4444
isDraggable={isDraggable}
4545
value={user}
4646
iconType="user"
47+
isAggregatable={true}
48+
fieldType="keyword"
4749
/>
4850
</EuiFlexItem>
4951
))
@@ -60,6 +62,8 @@ export const UserProcess = React.memo<{
6062
isDraggable={isDraggable}
6163
value={process}
6264
iconType="console"
65+
isAggregatable={true}
66+
fieldType="keyword"
6367
/>
6468
</EuiFlexItem>
6569
))

‎x-pack/plugins/security_solution/public/timelines/components/timeline/body/renderers/auditd/generic_details.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ export const AuditdGenericLine = React.memo<Props>(
106106
isDraggable={isDraggable}
107107
queryValue={result}
108108
value={result}
109+
isAggregatable={true}
110+
fieldType="keyword"
109111
/>
110112
</TokensFlexItem>
111113
</EuiFlexGroup>

‎x-pack/plugins/security_solution/public/timelines/components/timeline/body/renderers/auditd/primary_secondary_user_info.tsx‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ export const PrimarySecondary = React.memo<Props>(
3737
isDraggable={isDraggable}
3838
value={primary}
3939
iconType="user"
40+
isAggregatable={true}
41+
fieldType="keyword"
4042
/>
4143
);
4244
} else if (nilOrUnSet(primary) && !nilOrUnSet(secondary)) {
@@ -48,6 +50,8 @@ export const PrimarySecondary = React.memo<Props>(
4850
isDraggable={isDraggable}
4951
value={secondary}
5052
iconType="user"
53+
isAggregatable={true}
54+
fieldType="keyword"
5155
/>
5256
);
5357
} else if (primary === secondary) {
@@ -59,6 +63,8 @@ export const PrimarySecondary = React.memo<Props>(
5963
isDraggable={isDraggable}
6064
value={secondary}
6165
iconType="user"
66+
isAggregatable={true}
67+
fieldType="keyword"
6268
/>
6369
);
6470
} else {
@@ -72,6 +78,8 @@ export const PrimarySecondary = React.memo<Props>(
7278
isDraggable={isDraggable}
7379
value={primary}
7480
iconType="user"
81+
isAggregatable={true}
82+
fieldType="keyword"
7583
/>
7684
</TokensFlexItem>
7785
<TokensFlexItem grow={false} component="span">
@@ -85,6 +93,8 @@ export const PrimarySecondary = React.memo<Props>(
8593
isDraggable={isDraggable}
8694
value={secondary}
8795
iconType="user"
96+
isAggregatable={true}
97+
fieldType="keyword"
8898
/>
8999
</TokensFlexItem>
90100
</EuiFlexGroup>
@@ -123,6 +133,8 @@ export const PrimarySecondaryUserInfo = React.memo<PrimarySecondaryUserInfoProps
123133
isDraggable={isDraggable}
124134
value={userName}
125135
iconType="user"
136+
isAggregatable={true}
137+
fieldType="keyword"
126138
/>
127139
);
128140
} else if (!nilOrUnSet(userName) && nilOrUnSet(primary) && nilOrUnSet(secondary)) {
@@ -134,6 +146,8 @@ export const PrimarySecondaryUserInfo = React.memo<PrimarySecondaryUserInfoProps
134146
isDraggable={isDraggable}
135147
value={userName}
136148
iconType="user"
149+
isAggregatable={true}
150+
fieldType="keyword"
137151
/>
138152
);
139153
} else {

‎x-pack/plugins/security_solution/public/timelines/components/timeline/body/renderers/auditd/session_user_host_working_dir.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ export const SessionUserHostWorkingDir = React.memo<Props>(
5050
value={session}
5151
iconType="number"
5252
isDraggable={isDraggable}
53+
isAggregatable={true}
54+
fieldType="keyword"
5355
/>
5456
</TokensFlexItem>
5557
<TokensFlexItem grow={false} component="span">

‎x-pack/plugins/security_solution/public/timelines/components/timeline/body/renderers/dns/dns_request_event_details_line.tsx‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ export const DnsRequestEventDetailsLine = React.memo<Props>(
7676
field="dns.question.name"
7777
isDraggable={isDraggable}
7878
value={dnsQuestionName}
79+
isAggregatable={true}
80+
fieldType="keyword"
7981
/>
8082
</TokensFlexItem>
8183
</>
@@ -93,6 +95,8 @@ export const DnsRequestEventDetailsLine = React.memo<Props>(
9395
field="dns.question.type"
9496
isDraggable={isDraggable}
9597
value={dnsQuestionType}
98+
isAggregatable={true}
99+
fieldType="keyword"
96100
/>
97101
</TokensFlexItem>
98102
</>
@@ -110,6 +114,8 @@ export const DnsRequestEventDetailsLine = React.memo<Props>(
110114
field="dns.resolved_ip"
111115
isDraggable={isDraggable}
112116
value={dnsResolvedIp}
117+
isAggregatable={true}
118+
fieldType="ip"
113119
/>
114120
</TokensFlexItem>
115121
</>
@@ -130,6 +136,8 @@ export const DnsRequestEventDetailsLine = React.memo<Props>(
130136
field="dns.response_code"
131137
isDraggable={isDraggable}
132138
value={dnsResponseCode}
139+
isAggregatable={true}
140+
fieldType="keyword"
133141
/>
134142
</TokensFlexItem>
135143
<TokensFlexItem component="span" grow={false}>
@@ -165,6 +173,8 @@ export const DnsRequestEventDetailsLine = React.memo<Props>(
165173
field="event.code"
166174
isDraggable={isDraggable}
167175
value={eventCode}
176+
isAggregatable={true}
177+
fieldType="number"
168178
/>
169179
</TokensFlexItem>
170180
) : (
@@ -176,6 +186,8 @@ export const DnsRequestEventDetailsLine = React.memo<Props>(
176186
field="winlog.event_id"
177187
isDraggable={isDraggable}
178188
value={winlogEventId}
189+
isAggregatable={true}
190+
fieldType="keyword"
179191
/>
180192
</TokensFlexItem>
181193
)}

‎x-pack/plugins/security_solution/public/timelines/components/timeline/body/renderers/endgame/endgame_security_event_details_line.tsx‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,8 @@ export const EndgameSecurityEventDetailsLine = React.memo<Props>(
122122
isDraggable={isDraggable}
123123
queryValue={String(endgameLogonType)}
124124
value={`${endgameLogonType} - ${getHumanReadableLogonType(endgameLogonType)}`}
125+
isAggregatable={true}
126+
fieldType="keyword"
125127
/>
126128
</TokensFlexItem>
127129
</>
@@ -142,6 +144,8 @@ export const EndgameSecurityEventDetailsLine = React.memo<Props>(
142144
field="endgame.target_logon_id"
143145
isDraggable={isDraggable}
144146
value={endgameTargetLogonId}
147+
isAggregatable={true}
148+
fieldType="keyword"
145149
/>
146150
</TokensFlexItem>
147151
<TokensFlexItem component="span" grow={false}>
@@ -185,6 +189,8 @@ export const EndgameSecurityEventDetailsLine = React.memo<Props>(
185189
isDraggable={isDraggable}
186190
iconType="user"
187191
value={endgameSubjectUserName}
192+
isAggregatable={true}
193+
fieldType="keyword"
188194
/>
189195
</TokensFlexItem>
190196
</>
@@ -206,6 +212,8 @@ export const EndgameSecurityEventDetailsLine = React.memo<Props>(
206212
field="endgame.subject_domain_name"
207213
isDraggable={isDraggable}
208214
value={endgameSubjectDomainName}
215+
isAggregatable={true}
216+
fieldType="keyword"
209217
/>
210218
</TokensFlexItem>
211219
</>
@@ -226,6 +234,8 @@ export const EndgameSecurityEventDetailsLine = React.memo<Props>(
226234
field="endgame.subject_logon_id"
227235
isDraggable={isDraggable}
228236
value={endgameSubjectLogonId}
237+
isAggregatable={true}
238+
fieldType="keyword"
229239
/>
230240
</TokensFlexItem>
231241
<TokensFlexItem component="span" grow={false}>
@@ -243,6 +253,8 @@ export const EndgameSecurityEventDetailsLine = React.memo<Props>(
243253
eventId={id}
244254
field="event.code"
245255
value={eventCode}
256+
isAggregatable={true}
257+
fieldType="keyword"
246258
/>
247259
</TokensFlexItem>
248260
) : (
@@ -253,6 +265,8 @@ export const EndgameSecurityEventDetailsLine = React.memo<Props>(
253265
iconType="logoWindows"
254266
field="winlog.event_id"
255267
value={winlogEventId}
268+
isAggregatable={true}
269+
fieldType="keyword"
256270
/>
257271
</TokensFlexItem>
258272
)}

0 commit comments

Comments
 (0)