Skip to content

Commit 8eeb9e2

Browse files
authored
Fix static value converter (#144034)
1 parent 7839589 commit 8eeb9e2

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/static_value.test.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,11 @@ describe('convertToStaticValueColumn', () => {
4747
[{ series, metrics: [metric], dataView }, { visibleSeriesCount: 1 }],
4848
null,
4949
],
50+
[
51+
'null if value is not specified',
52+
[{ series, metrics: [metric], dataView }, { visibleSeriesCount: 2 }],
53+
null,
54+
],
5055
[
5156
'static value column',
5257
[{ series, metrics: [{ ...metric, value: 'some value' }], dataView }],

src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/static_value.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ export const convertToStaticValueColumn = (
3232
return null;
3333
}
3434
const currentMetric = metrics[metrics.length - 1];
35+
if (!currentMetric.value) {
36+
return null;
37+
}
3538
return {
3639
operationType: 'static_value',
3740
references: [],
@@ -68,7 +71,10 @@ export const convertStaticValueToFormulaColumn = (
6871
return null;
6972
}
7073
const currentMetric = metrics[metrics.length - 1];
71-
return createFormulaColumn(currentMetric.value ?? '', {
74+
if (!currentMetric.value) {
75+
return null;
76+
}
77+
return createFormulaColumn(currentMetric.value, {
7278
series,
7379
metric: currentMetric,
7480
dataView,

0 commit comments

Comments
 (0)