remove trackOverlays that now is handled internally

mbondyra · mbondyra · commit 87adb36c5991 · 2025-07-11T09:04:25.000+02:00
diff --git a/src/platform/plugins/shared/controls/public/controls/esql_control/get_esql_control_factory.tsx b/src/platform/plugins/shared/controls/public/controls/esql_control/get_esql_control_factory.tsx
@@ -13,9 +13,8 @@ import { BehaviorSubject, merge } from 'rxjs';
 import { css } from '@emotion/react';
 import { EuiComboBox } from '@elastic/eui';
 import { apiPublishesESQLVariables, type ESQLControlState } from '@kbn/esql-types';
-import { useBatchedPublishingSubjects, apiHasParentApi } from '@kbn/presentation-publishing';
+import { useBatchedPublishingSubjects } from '@kbn/presentation-publishing';
 import { initializeUnsavedChanges } from '@kbn/presentation-containers';
-import { tracksOverlays } from '@kbn/presentation-util';
 import { ESQL_CONTROL } from '../../../common';
 import type { ESQLControlApi } from './types';
 import { ControlFactory } from '../types';
@@ -43,19 +42,13 @@ export const getESQLControlFactory = (): ControlFactory<ESQLControlState, ESQLCo
         controlGroupApi.controlFetch$(uuid)
       );
 
-      const closeOverlay = () => {
-        if (apiHasParentApi(controlGroupApi) && tracksOverlays(controlGroupApi.parentApi)) {
-          controlGroupApi.parentApi.clearOverlays();
-        }
-      };
       const onSaveControl = (updatedState: ESQLControlState) => {
         controlGroupApi?.replacePanel(uuid, {
           panelType: 'esqlControl',
           serializedState: {
             rawState: updatedState,
           },
         });
-        closeOverlay();
       };
 
       function serializeState() {
@@ -107,7 +100,6 @@ export const getESQLControlFactory = (): ControlFactory<ESQLControlState, ESQLCo
               controlType: initialState.controlType,
               esqlVariables: variablesInParent,
               onSaveControl,
-              onCancelControl: closeOverlay,
               initialState: state,
             });
           } catch (e) {
