Skip to content

Commit 86bfdd9

Browse files
kibanamachinerylnd
kibanamachine
and
rylnd
authored
[9.0] [Detection Engine] Fix and unskip cypress suite related to ES|QL rule creation (#222467) (#223059)
# Backport This will backport the following commits from `main` to `9.0`: - [[Detection Engine] Fix and unskip cypress suite related to ES|QL rule creation (#222467)](#222467) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ryland Herrick","email":"ryalnd@gmail.com"},"sourceCommit":{"committedDate":"2025-06-06T20:55:20Z","message":"[Detection Engine] Fix and unskip cypress suite related to ES|QL rule creation (#222467)\n\nA [recent change](https://github.com/elastic/elasticsearch/pull/128464)\nto the ES|QL syntax seems to have broken this test, which assumed that\nthe clause `limit 5 true` is a syntax error in ES|QL.\n\nRegardless of whether or not that's correct, the test just needs a\nsyntactically-invalid (and non-aggregating) query, which it now has,\nagain. Closes https://github.com/elastic/kibana/issues/222182.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"0fb44f87cdb60df506827ee1e7c07dd4dafdba83","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:Rule Creation","Team:Detection Engine","backport:version","Feature: ES|QL Rule","8.19 candidate","v9.1.0","v8.19.0"],"title":"[Detection Engine] Fix and unskip cypress suite related to ES|QL rule creation","number":222467,"url":"https://github.com/elastic/kibana/pull/222467","mergeCommit":{"message":"[Detection Engine] Fix and unskip cypress suite related to ES|QL rule creation (#222467)\n\nA [recent change](https://github.com/elastic/elasticsearch/pull/128464)\nto the ES|QL syntax seems to have broken this test, which assumed that\nthe clause `limit 5 true` is a syntax error in ES|QL.\n\nRegardless of whether or not that's correct, the test just needs a\nsyntactically-invalid (and non-aggregating) query, which it now has,\nagain. Closes https://github.com/elastic/kibana/issues/222182.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"0fb44f87cdb60df506827ee1e7c07dd4dafdba83"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222467","number":222467,"mergeCommit":{"message":"[Detection Engine] Fix and unskip cypress suite related to ES|QL rule creation (#222467)\n\nA [recent change](https://github.com/elastic/elasticsearch/pull/128464)\nto the ES|QL syntax seems to have broken this test, which assumed that\nthe clause `limit 5 true` is a syntax error in ES|QL.\n\nRegardless of whether or not that's correct, the test just needs a\nsyntactically-invalid (and non-aggregating) query, which it now has,\nagain. Closes https://github.com/elastic/kibana/issues/222182.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"0fb44f87cdb60df506827ee1e7c07dd4dafdba83"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
1 parent d8c6c5c commit 86bfdd9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/rule_creation

‎x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/rule_creation/esql_rule.cy.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ describe(
171171
});
172172

173173
it('shows syntax error when query is syntactically invalid - prioritizing it over missing metadata operator error', function () {
174-
const invalidNonAggregatingQuery = 'from auditbeat* | limit 5 test';
174+
const invalidNonAggregatingQuery = 'from auditbeat* | where true test';
175175
selectEsqlRuleType();
176176
fillEsqlQueryBar(invalidNonAggregatingQuery);
177177
getDefineContinueButton().click();

0 commit comments

Comments
 (0)