♻️ some more description

dej611 · dej611 · commit 770f3f7a4a83 · 2023-04-19T16:19:58.000+02:00
diff --git a/x-pack/plugins/lens/public/visualizations/gauge/visualization.tsx b/x-pack/plugins/lens/public/visualizations/gauge/visualization.tsx
@@ -235,23 +235,7 @@ export const getGaugeVisualization = ({
   getSuggestions,
 
   getConfiguration({ state, frame }) {
-    // const hasColoring = Boolean(state.colorMode !== 'none' && state.palette?.params?.stops);
-
     const row = state?.layerId ? frame?.activeData?.[state?.layerId]?.rows?.[0] : undefined;
-    // const { metricAccessor } = state ?? {};
-
-    // const accessors = getAccessorsFromState(state);
-
-    // let palette;
-    // if (!(row == null || metricAccessor == null || state?.palette == null || !hasColoring)) {
-    //   const currentMinMax = {
-    //     min: getMinValue(row, accessors),
-    //     max: getMaxValue(row, accessors),
-    //   };
-
-    //   const displayStops = applyPaletteParams(paletteService, state?.palette, currentMinMax);
-    //   palette = displayStops.map(({ color }) => color);
-    // }
     const { palette, metricAccessor, accessors } = getConfigurationAccessorsAndPalette(
       state,
       paletteService,
diff --git a/x-pack/plugins/lens/public/visualizations/partition/visualization.tsx b/x-pack/plugins/lens/public/visualizations/partition/visualization.tsx
@@ -675,6 +675,9 @@ export const getPieVisualization = ({
           )
         );
       } else if (!layer.primaryGroups?.length) {
+        // This is a logic integrated in the renderer, here simulated
+        // In the particular case of no color assigned (as no sliceBy dimension defined)
+        // the color is generated on the fly from the default palette
         palette.push(
           ...paletteService
             .get(state.palette?.name || 'default')
diff --git a/x-pack/plugins/lens/public/visualizations/xy/visualization.test.ts b/x-pack/plugins/lens/public/visualizations/xy/visualization.test.ts
@@ -2242,6 +2242,7 @@ describe('xy_visualization', () => {
         expect(yConfigs?.accessors[1].columnId).toEqual('b');
         expect(yConfigs?.accessors[1].color).toEqual('green');
 
+        // This call restores the initial state of the paletteGetter
         paletteGetter.mockRestore();
       });
     });
