feedbacks

tsullivan · tsullivan · commit 74b48d9d2624 · 2020-04-15T11:45:44.000-07:00
diff --git a/x-pack/legacy/plugins/reporting/server/lib/esqueue/worker.js b/x-pack/legacy/plugins/reporting/server/lib/esqueue/worker.js
@@ -285,13 +285,10 @@ export class Worker extends events.EventEmitter {
         const completedTime = moment().toISOString();
         const docOutput = this._formatOutput(output);
 
-        let status;
-        if (output && output.warnings && output.warnings.length > 0) {
-          status = constants.JOB_STATUS_WARNINGS;
-        } else {
-          status = constants.JOB_STATUS_COMPLETED;
-        }
-
+        const status =
+          output && output.warnings && output.warnings.length > 0
+            ? constants.JOB_STATUS_WARNINGS
+            : constants.JOB_STATUS_COMPLETED;
         const doc = {
           status,
           completed_at: completedTime,
diff --git a/x-pack/legacy/plugins/reporting/types.d.ts b/x-pack/legacy/plugins/reporting/types.d.ts
@@ -8,6 +8,7 @@ import { EventEmitter } from 'events';
 import { ResponseObject } from 'hapi';
 import { Legacy } from 'kibana';
 import { CallCluster } from '../../../../src/legacy/core_plugins/elasticsearch';
+import { JobStatus } from '../../../plugins/reporting'; // reporting new platform
 import { CancellationToken } from './common/cancellation_token';
 import { ReportingCore } from './server/core';
 import { LevelLogger } from './server/lib/level_logger';
@@ -150,7 +151,7 @@ export interface JobSource<JobParamsType> {
     jobtype: string;
     output: JobDocOutput;
     payload: JobDocPayload<JobParamsType>;
-    status: string; // completed, failed, etc
+    status: JobStatus;
   };
 }
 
