[Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert (#96633)

nreese · kibanamachine · nreese · commit 719568cd778a · 2021-04-08T20:15:01.000-06:00
* [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert

* tslint

* instead of forcing refresh on getIdsAndTitles, update index pattern service to add saved object to cache when index pattern is created

* simplify title check

* revert unneeded changes

* tslint

* api doc updates

* fix functional test

Co-authored-by: Kibana Machine &lt;42973632+kibanamachine@users.noreply.github.com&gt;
# Conflicts:
#	docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchbar.md
diff --git a/docs/development/plugins/data/public/kibana-plugin-plugins-data-public.indexpatternselectprops.md b/docs/development/plugins/data/public/kibana-plugin-plugins-data-public.indexpatternselectprops.md
@@ -12,6 +12,5 @@ export declare type IndexPatternSelectProps = Required<Omit<EuiComboBoxProps<any
     indexPatternId: string;
     fieldTypes?: string[];
     onNoIndexPatterns?: () => void;
-    maxIndexPatterns?: number;
 };
 ```
diff --git a/src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts b/src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts
@@ -567,6 +567,9 @@ export class IndexPatternsService {
     });
     indexPattern.id = response.id;
     this.indexPatternCache.set(indexPattern.id, Promise.resolve(indexPattern));
+    if (this.savedObjectsCache) {
+      this.savedObjectsCache.push(response as SavedObject<IndexPatternSavedObjectAttrs>);
+    }
     return indexPattern;
   }
 
diff --git a/src/plugins/data/public/public.api.md b/src/plugins/data/public/public.api.md
@@ -1537,7 +1537,6 @@ export type IndexPatternSelectProps = Required<Omit<EuiComboBoxProps<any>, 'isLo
     indexPatternId: string;
     fieldTypes?: string[];
     onNoIndexPatterns?: () => void;
-    maxIndexPatterns?: number;
 };
 
 // Warning: (ae-missing-release-tag) "IndexPatternSpec" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
diff --git a/src/plugins/data/public/ui/index_pattern_select/index_pattern_select.tsx b/src/plugins/data/public/ui/index_pattern_select/index_pattern_select.tsx
@@ -25,7 +25,6 @@ export type IndexPatternSelectProps = Required<
   indexPatternId: string;
   fieldTypes?: string[];
   onNoIndexPatterns?: () => void;
-  maxIndexPatterns?: number;
 };
 
 export type IndexPatternSelectInternalProps = IndexPatternSelectProps & {
@@ -42,10 +41,6 @@ interface IndexPatternSelectState {
 // Needed for React.lazy
 // eslint-disable-next-line import/no-default-export
 export default class IndexPatternSelect extends Component<IndexPatternSelectInternalProps> {
-  static defaultProps: {
-    maxIndexPatterns: 1000;
-  };
-
   private isMounted: boolean = false;
   state: IndexPatternSelectState;
 
@@ -67,7 +62,7 @@ export default class IndexPatternSelect extends Component<IndexPatternSelectInte
 
   componentDidMount() {
     this.isMounted = true;
-    this.fetchOptions();
+    this.fetchOptions('');
     this.fetchSelectedIndexPattern(this.props.indexPatternId);
   }
 
@@ -107,39 +102,59 @@ export default class IndexPatternSelect extends Component<IndexPatternSelectInte
   };
 
   debouncedFetch = _.debounce(async (searchValue: string) => {
-    const { fieldTypes, onNoIndexPatterns, indexPatternService } = this.props;
-    const indexPatterns = await indexPatternService.find(
-      `${searchValue}*`,
-      this.props.maxIndexPatterns
-    );
+    const isCurrentSearch = () => {
+      return this.isMounted && searchValue === this.state.searchValue;
+    };
 
-    // We need this check to handle the case where search results come back in a different
-    // order than they were sent out. Only load results for the most recent search.
-    if (searchValue !== this.state.searchValue || !this.isMounted) {
+    const idsAndTitles = await this.props.indexPatternService.getIdsWithTitle();
+    if (!isCurrentSearch()) {
       return;
     }
 
-    const options = indexPatterns
-      .filter((indexPattern) => {
-        return fieldTypes
-          ? indexPattern.fields.some((field) => {
-              return fieldTypes.includes(field.type);
-            })
-          : true;
-      })
-      .map((indexPattern) => {
-        return {
-          label: indexPattern.title,
-          value: indexPattern.id,
-        };
+    const options = [];
+    for (let i = 0; i < idsAndTitles.length; i++) {
+      if (!idsAndTitles[i].title.toLowerCase().includes(searchValue.toLowerCase())) {
+        // index pattern excluded due to title not matching search
+        continue;
+      }
+
+      if (this.props.fieldTypes) {
+        try {
+          const indexPattern = await this.props.indexPatternService.get(idsAndTitles[i].id);
+          if (!isCurrentSearch()) {
+            return;
+          }
+          const hasRequiredFieldTypes = indexPattern.fields.some((field) => {
+            return this.props.fieldTypes!.includes(field.type);
+          });
+          if (!hasRequiredFieldTypes) {
+            continue;
+          }
+        } catch (err) {
+          // could not load index pattern, exclude it from list.
+          continue;
+        }
+      }
+
+      options.push({
+        label: idsAndTitles[i].title,
+        value: idsAndTitles[i].id,
       });
+
+      // Loading each index pattern object requires a network call so just find small number of matching index patterns
+      // Users can use 'searchValue' to further refine the list and locate their index pattern.
+      if (options.length > 15) {
+        break;
+      }
+    }
+
     this.setState({
       isLoading: false,
       options,
     });
 
-    if (onNoIndexPatterns && searchValue === '' && options.length === 0) {
-      onNoIndexPatterns();
+    if (this.props.onNoIndexPatterns && searchValue === '' && options.length === 0) {
+      this.props.onNoIndexPatterns();
     }
   }, 300);
 
diff --git a/test/functional/apps/visualize/input_control_vis/input_control_options.ts b/test/functional/apps/visualize/input_control_vis/input_control_options.ts
@@ -31,7 +31,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       );
       await PageObjects.visEditor.clickVisEditorTab('controls');
       await PageObjects.visEditor.addInputControl();
-      await comboBox.set('indexPatternSelect-0', 'logstash- ');
+      await comboBox.set('indexPatternSelect-0', 'logstash-');
       await comboBox.set('fieldSelect-0', FIELD_NAME);
       await PageObjects.visEditor.clickGo();
     });

Original file line number	Diff line number	Diff line change
`@@ -567,6 +567,9 @@ export class IndexPatternsService {`
`567`	`567`	`});`
`568`	`568`	`indexPattern.id = response.id;`
`569`	`569`	`this.indexPatternCache.set(indexPattern.id, Promise.resolve(indexPattern));`
	`570`	`+ if (this.savedObjectsCache) {`
	`571`	`+ this.savedObjectsCache.push(response as SavedObject<IndexPatternSavedObjectAttrs>);`
	`572`	`+ }`
`570`	`573`	`return indexPattern;`
`571`	`574`	`}`
`572`	`575`