Skip to content

Commit 70abcc0

Browse files
committed
Fix type issue
1 parent 99c81e2 commit 70abcc0

2 files changed

Lines changed: 2 additions & 11 deletions

File tree

x-pack/plugins/infra/public/components/alerting/metrics/expression.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ interface Props {
5656
errors: IErrorObject[];
5757
alertParams: {
5858
criteria: MetricExpression[];
59-
groupBy?: string | null;
59+
groupBy?: string;
6060
filterQuery?: string;
6161
};
6262
alertsContext: AlertsContextValue<AlertContextMeta>;
@@ -135,7 +135,7 @@ export const Expressions: React.FC<Props> = props => {
135135

136136
const onGroupByChange = useCallback(
137137
(group: string | null) => {
138-
setAlertParams('groupBy', group);
138+
setAlertParams('groupBy', group || undefined);
139139
},
140140
[setAlertParams]
141141
);

x-pack/plugins/infra/public/components/waffle/node_context_menu.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -145,15 +145,6 @@ export const NodeContextMenu: React.FC<Props> = ({
145145
isDisabled: !showUptimeLink,
146146
};
147147

148-
const alertMenuItem: SectionLinkProps = {
149-
label: i18n.translate('xpack.infra.nodeContextMenu.createAlertLink', {
150-
defaultMessage: 'Create Alert',
151-
}),
152-
onClick: () => {
153-
setFlyoutVisible(true);
154-
},
155-
};
156-
157148
return (
158149
<>
159150
<ActionMenu

0 commit comments

Comments
 (0)