Fix race condition causing data-complete to fail

Heenawter · Heenawter · commit 6fd58c512a3a · 2024-04-04T13:31:30.000-06:00
diff --git a/packages/presentation/presentation_publishing/publishing_subject/publishing_batcher.ts b/packages/presentation/presentation_publishing/publishing_subject/publishing_batcher.ts
@@ -73,9 +73,9 @@ export const useBatchedPublishingSubjects = <SubjectsType extends [...AnyPublish
     if (definedSubjects.length === 0) return;
     const subscription = combineLatest(definedSubjects)
       .pipe(
-        debounceTime(0),
         // When a new observer subscribes to a BehaviorSubject, it immediately receives the current value. Skip this emit.
-        skip(1)
+        skip(1),
+        debounceTime(0)
       )
       .subscribe((values) => {
         setLatestPublishedValues((lastPublishedValues) => {
diff --git a/src/plugins/image_embeddable/public/image_embeddable/get_image_embeddable_factory.tsx b/src/plugins/image_embeddable/public/image_embeddable/get_image_embeddable_factory.tsx
@@ -51,7 +51,7 @@ export const getImageEmbeddableFactory = ({
 
       const filesClient = filesService.filesClientFactory.asUnscoped<FileImageMetadata>();
       const imageConfig$ = new BehaviorSubject<ImageConfig>(initialState.imageConfig);
-      const dataLoading$ = new BehaviorSubject<boolean | undefined>(undefined);
+      const dataLoading$ = new BehaviorSubject<boolean | undefined>(true);
 
       const embeddable = buildApi(
         {

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ export const getImageEmbeddableFactory = ({`
`51`	`51`
`52`	`52`	`const filesClient = filesService.filesClientFactory.asUnscoped<FileImageMetadata>();`
`53`	`53`	`const imageConfig$ = new BehaviorSubject<ImageConfig>(initialState.imageConfig);`
`54`		`- const dataLoading$ = new BehaviorSubject<boolean \| undefined>(undefined);`
	`54`	`+ const dataLoading$ = new BehaviorSubject<boolean \| undefined>(true);`
`55`	`55`
`56`	`56`	`const embeddable = buildApi(`
`57`	`57`	`{`