allow null values in session storage backups.

ThomThomson · ThomThomson · commit 6f4caf8e6bb8 · 2024-06-19T16:48:47.000-04:00
diff --git a/examples/embeddable_examples/public/react_embeddables/saved_book/saved_book_react_embeddable.tsx b/examples/embeddable_examples/public/react_embeddables/saved_book/saved_book_react_embeddable.tsx
@@ -35,7 +35,7 @@ import {
 const bookSerializedStateIsByReference = (
   state?: BookSerializedState
 ): state is BookByReferenceSerializedState => {
-  return Boolean(state && (state as BookByReferenceSerializedState).savedBookId !== undefined);
+  return Boolean(state && (state as BookByReferenceSerializedState).savedBookId);
 };
 
 export const getSavedBookEmbeddableFactory = (core: CoreStart) => {
@@ -86,7 +86,7 @@ export const getSavedBookEmbeddableFactory = (core: CoreStart) => {
               defaultMessage: 'book',
             }),
           serializeState: async () => {
-            if (savedBookId$.value === undefined) {
+            if (!Boolean(savedBookId$.value)) {
               // if this book is currently by value, we serialize the entire state.
               const bookByValueState: BookByValueSerializedState = {
                 attributes: serializeBookAttributes(bookAttributesManager),
@@ -97,7 +97,7 @@ export const getSavedBookEmbeddableFactory = (core: CoreStart) => {
 
             // if this book is currently by reference, we serialize the reference and write to the external store.
             const bookByReferenceState: BookByReferenceSerializedState = {
-              savedBookId: savedBookId$.value,
+              savedBookId: savedBookId$.value!,
               ...serializeTitles(),
             };
 
diff --git a/src/plugins/dashboard/public/dashboard_actions/unlink_from_library_action.tsx b/src/plugins/dashboard/public/dashboard_actions/unlink_from_library_action.tsx
@@ -77,7 +77,7 @@ export class UnlinkFromLibraryAction implements Action<EmbeddableApiContext> {
       return api.canUnlinkFromLibrary();
     } else if (apiHasInPlaceLibraryTransforms(api)) {
       const canUnLink = api.canUnlinkFromLibrary ? await api.canUnlinkFromLibrary() : true;
-      return canUnLink && api.libraryId$.value !== undefined;
+      return canUnLink && Boolean(api.libraryId$.value);
     }
     throw new IncompatibleActionError();
   }
diff --git a/src/plugins/dashboard/public/services/dashboard_backup/dashboard_backup_service.ts b/src/plugins/dashboard/public/services/dashboard_backup/dashboard_backup_service.ts
@@ -133,7 +133,7 @@ class DashboardBackupService implements DashboardBackupServiceType {
 
       const panelsStorage = this.sessionStorage.get(DASHBOARD_PANELS_SESSION_KEY) ?? {};
       set(panelsStorage, [this.activeSpaceId, id], unsavedPanels);
-      this.sessionStorage.set(DASHBOARD_PANELS_SESSION_KEY, panelsStorage);
+      this.sessionStorage.set(DASHBOARD_PANELS_SESSION_KEY, panelsStorage, true);
     } catch (e) {
       this.notifications.toasts.addDanger({
         title: backupServiceStrings.getPanelsSetError(e.message),
diff --git a/src/plugins/kibana_utils/public/storage/storage.ts b/src/plugins/kibana_utils/public/storage/storage.ts
@@ -32,9 +32,13 @@ export class Storage implements IStorageWrapper {
     }
   };
 
-  public set = (key: string, value: any) => {
+  public set = (key: string, value: any, includeUndefined: boolean = false) => {
+    const replacer = includeUndefined
+      ? (_: string, currentValue: any) =>
+          typeof currentValue === 'undefined' ? null : currentValue
+      : undefined;
     try {
-      return this.store.setItem(key, JSON.stringify(value));
+      return this.store.setItem(key, JSON.stringify(value, replacer));
     } catch (e) {
       return false;
     }

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ export class UnlinkFromLibraryAction implements Action<EmbeddableApiContext> {`
`77`	`77`	`return api.canUnlinkFromLibrary();`
`78`	`78`	`} else if (apiHasInPlaceLibraryTransforms(api)) {`
`79`	`79`	`const canUnLink = api.canUnlinkFromLibrary ? await api.canUnlinkFromLibrary() : true;`
`80`		`- return canUnLink && api.libraryId$.value !== undefined;`
	`80`	`+ return canUnLink && Boolean(api.libraryId$.value);`
`81`	`81`	`}`
`82`	`82`	`throw new IncompatibleActionError();`
`83`	`83`	`}`