[8.6] [Security Solution] Fixes bulk close alerts from exception flyout type bug (#150765) (#150783)

kibanamachine · dplumlee · web-flow · commit 6de41514aa27 · 2023-02-09T15:26:20.000-07:00
# Backport This will backport the following commits from `main` to `8.6`: - [[Security Solution] Fixes bulk close alerts from exception flyout type bug (#150765)](#150765)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/utils/helpers.test.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/utils/helpers.test.tsx
@@ -384,6 +384,16 @@ describe('Exception helpers', () => {
       const result = prepareExceptionItemsForBulkClose(payload);
       expect(result).toEqual(expected);
     });
+
+    test("should strip out any comments in the exceptions for bulk close'", () => {
+      const exceptionItemWithComment = {
+        ...getExceptionListItemSchemaMock(),
+        comments: getCommentsArrayMock(),
+      };
+      const payload = [exceptionItemWithComment];
+      const result = prepareExceptionItemsForBulkClose(payload);
+      expect(result).toEqual([getExceptionListItemSchemaMock()]);
+    });
   });
 
   describe('#lowercaseHashValues', () => {
diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/utils/helpers.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/utils/helpers.tsx
@@ -154,9 +154,10 @@ export const prepareExceptionItemsForBulkClose = (
       return {
         ...item,
         entries: newEntries,
+        comments: [], // Strips out unneeded comments attribute for bulk close as they are not needed and are throwing type errors
       };
     } else {
-      return item;
+      return { ...item, comments: [] };
     }
   });
 };
