Skip to content

Commit 6baa9de

Browse files
[9.3] Cleanup unused dependency on security-plugin (#249903) (#250007)
# Backport This will backport the following commits from `main` to `9.3`: - [Cleanup unused dependency on `security-plugin` (#249903)](#249903) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2026-01-22T10:30:43Z","message":"Cleanup unused dependency on `security-plugin` (#249903)\n\n## Summary\n\nThe dependency was introduced but not used","sha":"95438591fde88889c2820deec046e7de6e7da37c","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting","backport:all-open","v9.4.0"],"title":"Cleanup unused dependency on `security-plugin`","number":249903,"url":"https://github.com/elastic/kibana/pull/249903","mergeCommit":{"message":"Cleanup unused dependency on `security-plugin` (#249903)\n\n## Summary\n\nThe dependency was introduced but not used","sha":"95438591fde88889c2820deec046e7de6e7da37c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/249903","number":249903,"mergeCommit":{"message":"Cleanup unused dependency on `security-plugin` (#249903)\n\n## Summary\n\nThe dependency was introduced but not used","sha":"95438591fde88889c2820deec046e7de6e7da37c"}}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>
1 parent b59e849 commit 6baa9de

6 files changed

Lines changed: 3 additions & 18 deletions

File tree

x-pack/platform/plugins/shared/timelines/kibana.jsonc

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@
2121
"kibanaReact",
2222
"kibanaUtils"
2323
],
24-
"optionalPlugins": [
25-
"security"
26-
],
24+
"optionalPlugins": [],
2725
"extraPublicDirs": [
2826
"common"
2927
]

x-pack/platform/plugins/shared/timelines/moon.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ dependsOn:
3434
- '@kbn/ui-theme'
3535
- '@kbn/i18n-react'
3636
- '@kbn/i18n'
37-
- '@kbn/security-plugin'
3837
- '@kbn/safer-lodash-set'
3938
- '@kbn/alerts-as-data-utils'
4039
- '@kbn/logging'

x-pack/platform/plugins/shared/timelines/server/plugin.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import type {
1313
Logger,
1414
} from '@kbn/core/server';
1515

16-
import type { SecurityPluginSetup } from '@kbn/security-plugin/server';
1716
import type { SetupPlugins, StartPlugins, TimelinesPluginUI, TimelinesPluginStart } from './types';
1817
import { timelineSearchStrategyProvider } from './search_strategy/timeline';
1918
import { timelineEqlSearchStrategyProvider } from './search_strategy/timeline/eql';
@@ -25,7 +24,6 @@ export class TimelinesPlugin
2524
implements Plugin<TimelinesPluginUI, TimelinesPluginStart, SetupPlugins, StartPlugins>
2625
{
2726
private readonly logger: Logger;
28-
private security?: SecurityPluginSetup;
2927

3028
constructor(initializerContext: PluginInitializerContext) {
3129
this.logger = initializerContext.logger.get();
@@ -38,16 +36,11 @@ export class TimelinesPlugin
3836

3937
public setup(core: CoreSetup<StartPlugins, TimelinesPluginStart>, plugins: SetupPlugins) {
4038
this.logger.debug('timelines: Setup');
41-
this.security = plugins.security;
4239

4340
const IndexFields = indexFieldsProvider(core.getStartServices);
4441
// Register search strategy
4542
void core.getStartServices().then(([_, depsStart]) => {
46-
const TimelineSearchStrategy = timelineSearchStrategyProvider(
47-
depsStart.data,
48-
this.logger,
49-
this.security
50-
);
43+
const TimelineSearchStrategy = timelineSearchStrategyProvider(depsStart.data, this.logger);
5144
const TimelineEqlSearchStrategy = timelineEqlSearchStrategyProvider(depsStart.data);
5245

5346
plugins.data.search.registerSearchStrategy('indexFields', IndexFields);

x-pack/platform/plugins/shared/timelines/server/search_strategy/timeline/index.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import type {
1414
import { shimHitsTotal } from '@kbn/data-plugin/server';
1515
import type { ISearchOptions } from '@kbn/search-types';
1616
import { ENHANCED_ES_SEARCH_STRATEGY } from '@kbn/data-plugin/common';
17-
import type { SecurityPluginSetup } from '@kbn/security-plugin/server';
1817
import type { Logger } from '@kbn/logging';
1918
import type { z } from '@kbn/zod';
2019

@@ -30,8 +29,7 @@ import { isAggCardinalityAggregate } from './factory/helpers/is_agg_cardinality_
3029

3130
export const timelineSearchStrategyProvider = (
3231
data: PluginStart,
33-
logger: Logger,
34-
_security?: SecurityPluginSetup
32+
logger: Logger
3533
// eslint-disable-next-line @typescript-eslint/no-explicit-any
3634
): ISearchStrategy<z.input<typeof searchStrategyRequestSchema>, any> => {
3735
const es = data.search.getSearchStrategy(ENHANCED_ES_SEARCH_STRATEGY);

x-pack/platform/plugins/shared/timelines/server/types.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
import type { PluginSetup, PluginStart } from '@kbn/data-plugin/server';
99
import type { AlertingServerStart } from '@kbn/alerting-plugin/server';
10-
import type { SecurityPluginSetup } from '@kbn/security-plugin/server';
1110

1211
// eslint-disable-next-line @typescript-eslint/no-empty-interface
1312
export interface TimelinesPluginUI {}
@@ -16,7 +15,6 @@ export interface TimelinesPluginStart {}
1615

1716
export interface SetupPlugins {
1817
data: PluginSetup;
19-
security?: SecurityPluginSetup;
2018
}
2119

2220
export interface StartPlugins {

x-pack/platform/plugins/shared/timelines/tsconfig.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
"@kbn/ui-theme",
3131
"@kbn/i18n-react",
3232
"@kbn/i18n",
33-
"@kbn/security-plugin",
3433
"@kbn/safer-lodash-set",
3534
"@kbn/alerts-as-data-utils",
3635
"@kbn/logging",

0 commit comments

Comments
 (0)