Flag nested fields as non-aggregatable

Bargs · Bargs · commit 69c30aa0f780 · 2019-11-26T15:33:52.000-05:00
diff --git a/src/plugins/data/server/index_patterns/fetcher/lib/field_capabilities/field_caps_response.test.js b/src/plugins/data/server/index_patterns/fetcher/lib/field_capabilities/field_caps_response.test.js
@@ -144,6 +144,13 @@ describe('index_patterns/field_capabilities/field_caps_response', () => {
         expect(child).toHaveProperty('subType', { nested: { path: 'nested_object_parent' } });
       });
 
+      it('returns nested sub-fields as non-aggregatable', () => {
+        const fields = readFieldCapsResponse(esResponse);
+        // Normally a keyword field would be aggregatable, but the fact that it is nested overrides that
+        const child = fields.find(f => f.name === 'nested_object_parent.child.keyword');
+        expect(child).toHaveProperty('aggregatable', false);
+      });
+
       it('handles fields that are both nested and multi', () => {
         const fields = readFieldCapsResponse(esResponse);
         const child = fields.find(f => f.name === 'nested_object_parent.child.keyword');
diff --git a/src/plugins/data/server/index_patterns/fetcher/lib/field_capabilities/field_caps_response.ts b/src/plugins/data/server/index_patterns/fetcher/lib/field_capabilities/field_caps_response.ts
@@ -182,6 +182,14 @@ export function readFieldCapsResponse(fieldCapsResponse: FieldCapsResponse): Fie
 
       if (Object.keys(subType).length > 0) {
         field.subType = subType;
+
+        // We don't support aggregating on nested fields, trying to do so in the UI will return
+        // blank results. For now we will stop showing nested fields as an option for aggregation.
+        // Once we add support for nested fields this condition should be removed and old index
+        // patterns should be migrated.
+        if (field.subType.nested) {
+          field.aggregatable = false;
+        }
       }
     }
   });

Original file line number	Diff line number	Diff line change
`@@ -182,6 +182,14 @@ export function readFieldCapsResponse(fieldCapsResponse: FieldCapsResponse): Fie`
`182`	`182`
`183`	`183`	`if (Object.keys(subType).length > 0) {`
`184`	`184`	`field.subType = subType;`
	`185`	`+`
	`186`	`+ // We don't support aggregating on nested fields, trying to do so in the UI will return`
	`187`	`+ // blank results. For now we will stop showing nested fields as an option for aggregation.`
	`188`	`+ // Once we add support for nested fields this condition should be removed and old index`
	`189`	`+ // patterns should be migrated.`
	`190`	`+ if (field.subType.nested) {`
	`191`	`+ field.aggregatable = false;`
	`192`	`+ }`
`185`	`193`	`}`
`186`	`194`	`}`
`187`	`195`	`});`