add correct max value

janmonschke · janmonschke · commit 65ef41ded850 · 2026-01-07T10:16:05.000+01:00
diff --git a/x-pack/platform/plugins/shared/cases/public/components/system_actions/cases/cases_params.test.tsx b/x-pack/platform/plugins/shared/cases/public/components/system_actions/cases/cases_params.test.tsx
@@ -113,6 +113,7 @@ describe('CasesParamsFields renders', () => {
     expect(await screen.findByTestId('time-window-unit-select')).toBeInTheDocument();
     expect(await screen.findByTestId('create-case-template-select')).toBeInTheDocument();
     expect(await screen.findByTestId('reopen-case')).toBeInTheDocument();
+    expect(await screen.findByTestId('maximum-case-to-open-input')).toBeInTheDocument();
   });
 
   it('renders loading state of grouping by fields correctly', async () => {
@@ -167,6 +168,22 @@ describe('CasesParamsFields renders', () => {
     expect(await screen.findByText('error')).toBeInTheDocument();
   });
 
+  it('renders the default maximum amount of cases correctly', async () => {
+    render(<CasesParamsFields {...defaultProps} />);
+
+    const maximumCasesInput = await screen.findByTestId('maximum-case-to-open-input');
+    expect(maximumCasesInput).toHaveValue(5);
+
+    // set to the maximum
+    fireEvent.change(maximumCasesInput, { target: { value: '20' } });
+    expect(editAction.mock.calls[0][1].maximumCasesToOpen).toEqual(20);
+    expect(maximumCasesInput).toBeValid();
+
+    // set to an invalid value
+    fireEvent.change(maximumCasesInput, { target: { value: '22' } });
+    expect(maximumCasesInput).toBeInvalid();
+  });
+
   describe('UI updates', () => {
     it('renders grouping by field options', async () => {
       render(<CasesParamsFields {...defaultProps} />);
diff --git a/x-pack/platform/plugins/shared/cases/public/components/system_actions/cases/cases_params.tsx b/x-pack/platform/plugins/shared/cases/public/components/system_actions/cases/cases_params.tsx
@@ -26,7 +26,11 @@ import { ATTACK_DISCOVERY_SCHEDULES_ALERT_TYPE_ID } from '@kbn/elastic-assistant
 import type { ServerlessProjectType } from '../../../../common/constants/types';
 import * as i18n from './translations';
 import type { CasesActionParams } from './types';
-import { CASES_CONNECTOR_SUB_ACTION, DEFAULT_MAX_OPEN_CASES } from '../../../../common/constants';
+import {
+  CASES_CONNECTOR_SUB_ACTION,
+  DEFAULT_MAX_OPEN_CASES,
+  MAX_OPEN_CASES,
+} from '../../../../common/constants';
 import { DEFAULT_TIME_WINDOW, TIME_UNITS } from './constants';
 import { getTimeUnitOptions } from './utils';
 import { useKibana } from '../../../common/lib/kibana';
@@ -309,10 +313,12 @@ export const CasesParamsFieldsComponent: React.FunctionComponent<
             <EuiFieldNumber
               fullWidth
               min={1}
-              max={DEFAULT_MAX_OPEN_CASES}
+              max={MAX_OPEN_CASES}
               step={1}
-              defaultValue={actionParams.subActionParams?.maximumCasesToOpen ?? 5}
-              data-test-subj="max-case-to-open-input"
+              defaultValue={
+                actionParams.subActionParams?.maximumCasesToOpen ?? DEFAULT_MAX_OPEN_CASES
+              }
+              data-test-subj="maximum-case-to-open-input"
               onChange={onChangeMaxCasesToOpend}
             />
           </EuiFormRow>
