- Scaling down deprecation issue panel title size to flow with typographic hierarchy.

dborodyansky · dborodyansky · commit 64e0f75dc4bc · 2021-10-15T11:35:28.000-07:00
- Removing panel around deprecation logging switch to reduce visual elements.
- Using success instead of green color for migration complete message.
diff --git a/x-pack/plugins/upgrade_assistant/public/application/components/overview/fix_issues_step/components/deprecation_issues_panel.tsx b/x-pack/plugins/upgrade_assistant/public/application/components/overview/fix_issues_step/components/deprecation_issues_panel.tsx
@@ -73,9 +73,10 @@ export const DeprecationIssuesPanel = (props: Props) => {
       className="upgDeprecationIssuesPanel"
       layout="horizontal"
       title={deprecationSource}
+      titleSize="xs"
       {...(!hasNoIssues && reactRouterNavigate(history, linkUrl))}
     >
-      <EuiSpacer />
+      <EuiSpacer size="s"/>
 
       {hasError ? (
         <LoadingIssuesError>{errorMessage}</LoadingIssuesError>
diff --git a/x-pack/plugins/upgrade_assistant/public/application/components/overview/fix_logs_step/fix_logs_step.tsx b/x-pack/plugins/upgrade_assistant/public/application/components/overview/fix_logs_step/fix_logs_step.tsx
@@ -25,9 +25,6 @@ const i18nTexts = {
   identifyStepTitle: i18n.translate('xpack.upgradeAssistant.overview.identifyStepTitle', {
     defaultMessage: 'Identify deprecated API use and update your applications',
   }),
-  toggleTitle: i18n.translate('xpack.upgradeAssistant.overview.toggleTitle', {
-    defaultMessage: 'Log Elasticsearch deprecation issues',
-  }),
   analyzeTitle: i18n.translate('xpack.upgradeAssistant.overview.analyzeTitle', {
     defaultMessage: 'Analyze deprecation logs',
   }),
@@ -140,21 +137,15 @@ const FixLogsStep: FunctionComponent<Props> = ({
 
   return (
     <>
-      <EuiText>
-        <h4>{i18nTexts.toggleTitle}</h4>
-      </EuiText>
-      <EuiSpacer size="m" />
-      <EuiPanel>
-        <DeprecationLoggingToggle
-          isDeprecationLogIndexingEnabled={isDeprecationLogIndexingEnabled}
-          isLoading={isLoading}
-          isUpdating={isUpdating}
-          fetchError={fetchError}
-          updateError={updateError}
-          resendRequest={resendRequest}
-          toggleLogging={toggleLogging}
-        />
-      </EuiPanel>
+      <DeprecationLoggingToggle
+        isDeprecationLogIndexingEnabled={isDeprecationLogIndexingEnabled}
+        isLoading={isLoading}
+        isUpdating={isUpdating}
+        fetchError={fetchError}
+        updateError={updateError}
+        resendRequest={resendRequest}
+        toggleLogging={toggleLogging}
+      />
 
       {onlyDeprecationLogWritingEnabled && (
         <>
diff --git a/x-pack/plugins/upgrade_assistant/public/application/components/overview/migrate_system_indices/migrate_system_indices.tsx b/x-pack/plugins/upgrade_assistant/public/application/components/overview/migrate_system_indices/migrate_system_indices.tsx
@@ -118,7 +118,7 @@ const MigrateSystemIndicesStep: FunctionComponent<Props> = ({ setIsComplete }) =
           <EuiIcon type="check" color="success" />
         </EuiFlexItem>
         <EuiFlexItem grow={false}>
-          <EuiText color="green">
+          <EuiText color="success">
             <p>{i18nTexts.noMigrationNeeded}</p>
           </EuiText>
         </EuiFlexItem>
