[Core] remove unused "pageNavigation" setting (#89160) (#90037)

mshustov · web-flow · commit 610a5b6d265f · 2021-02-03T08:48:47.000+01:00
* remove unused advanced setting

* remove docs
diff --git a/docs/management/advanced-options.asciidoc b/docs/management/advanced-options.asciidoc
@@ -134,11 +134,6 @@ The maximum numbers of buckets that a single data source can return. This might
 arise when the user selects a short interval (for example, 1s) for a long time
 period (1 year).
 
-[[pagenavigation]]`pageNavigation`::
-The style of navigation menu for Kibana. Choices are Legacy, the legacy style
-where every plugin is represented in the nav, and Modern, a new format that
-bundles related plugins together in flyaway nested navigation.
-
 [[query-allowleadingwildcards]]`query:allowLeadingWildcards`::
 Allows a wildcard (*) as the first character in a query clause. Only applies
 when experimental query features are enabled in the query bar. To disallow
diff --git a/src/core/server/ui_settings/settings/navigation.test.ts b/src/core/server/ui_settings/settings/navigation.test.ts
@@ -28,18 +28,4 @@ describe('navigation settings', () => {
       );
     });
   });
-
-  describe('pageNavigation', () => {
-    const validate = getValidationFn(navigationSettings.pageNavigation);
-
-    it('should only accept valid values', () => {
-      expect(() => validate('modern')).not.toThrow();
-      expect(() => validate('legacy')).not.toThrow();
-      expect(() => validate('invalid')).toThrowErrorMatchingInlineSnapshot(`
-"types that failed validation:
-- [0]: expected value to equal [modern]
-- [1]: expected value to equal [legacy]"
-`);
-    });
-  });
 });
diff --git a/src/core/server/ui_settings/settings/navigation.ts b/src/core/server/ui_settings/settings/navigation.ts
@@ -37,25 +37,5 @@ export const getNavigationSettings = (): Record<string, UiSettingsParams> => {
           'The route must be a relative URL.',
       }),
     },
-    pageNavigation: {
-      name: i18n.translate('core.ui_settings.params.pageNavigationName', {
-        defaultMessage: 'Side nav style',
-      }),
-      value: 'modern',
-      description: i18n.translate('core.ui_settings.params.pageNavigationDesc', {
-        defaultMessage: 'Change the style of navigation',
-      }),
-      type: 'select',
-      options: ['modern', 'legacy'],
-      optionLabels: {
-        modern: i18n.translate('core.ui_settings.params.pageNavigationModern', {
-          defaultMessage: 'Modern',
-        }),
-        legacy: i18n.translate('core.ui_settings.params.pageNavigationLegacy', {
-          defaultMessage: 'Legacy',
-        }),
-      },
-      schema: schema.oneOf([schema.literal('modern'), schema.literal('legacy')]),
-    },
   };
 };
diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts b/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts
@@ -77,7 +77,6 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
   'sort:options': { type: 'keyword' },
   'savedObjects:listingLimit': { type: 'long' },
   'query:queryString:options': { type: 'keyword' },
-  pageNavigation: { type: 'keyword' },
   'metrics:max_buckets': { type: 'long' },
   'query:allowLeadingWildcards': { type: 'boolean' },
   metaFields: { type: 'keyword' }, // it's an array
diff --git a/src/plugins/telemetry/schema/oss_plugins.json b/src/plugins/telemetry/schema/oss_plugins.json
@@ -3963,9 +3963,6 @@
         "query:queryString:options": {
           "type": "keyword"
         },
-        "pageNavigation": {
-          "type": "keyword"
-        },
         "metrics:max_buckets": {
           "type": "long"
         },
diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json
@@ -537,10 +537,6 @@
     "core.ui_settings.params.notifications.infoLifetimeTitle": "情報通知時間",
     "core.ui_settings.params.notifications.warningLifetimeText": "警告通知が画面に表示される時間（ミリ秒単位）です。{infinityValue}に設定すると、無効になります。",
     "core.ui_settings.params.notifications.warningLifetimeTitle": "警告通知時間",
-    "core.ui_settings.params.pageNavigationDesc": "ナビゲーションのスタイルを変更",
-    "core.ui_settings.params.pageNavigationLegacy": "レガシー",
-    "core.ui_settings.params.pageNavigationModern": "モダン",
-    "core.ui_settings.params.pageNavigationName": "サイドナビゲーションスタイル",
     "core.ui_settings.params.storeUrlText": "URLが長くなりすぎるためブラウザーが対応できない場合があります。セッションストレージにURLの一部を保存することでこの問題に対処できるかどうかをテストしています。結果を教えてください！",
     "core.ui_settings.params.storeUrlTitle": "セッションストレージにURLを格納",
     "core.ui_settings.params.themeVersionText": "現在のバージョンと次のバージョンのKibanaで使用されるテーマを切り替えます。この設定を適用するにはページの更新が必要です。",
diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
@@ -537,10 +537,6 @@
     "core.ui_settings.params.notifications.infoLifetimeTitle": "信息通知生存时间",
     "core.ui_settings.params.notifications.warningLifetimeText": "在屏幕上显示警告通知的时间（毫秒）。设置为 {infinityValue} 将禁用此项。",
     "core.ui_settings.params.notifications.warningLifetimeTitle": "警告通知生存时间",
-    "core.ui_settings.params.pageNavigationDesc": "更改导航样式",
-    "core.ui_settings.params.pageNavigationLegacy": "旧版",
-    "core.ui_settings.params.pageNavigationModern": "现代",
-    "core.ui_settings.params.pageNavigationName": "侧边导航样式",
     "core.ui_settings.params.storeUrlText": "有时，URL 可能会变得过长，使某些浏览器无法进行处理。为此，我们将正测试在会话存储中存储 URL 的组成部分是否会有所帮助。请向我们反馈您的体验！",
     "core.ui_settings.params.storeUrlTitle": "将 URL 存储在会话存储中",
     "core.ui_settings.params.themeVersionText": "在用于当前版和下一版 Kibana 的主题之间切换。需要刷新页面，才能应用设置。",
