Skip to content

Commit 5b40ebc

Browse files
author
Liza K
committed
types
1 parent 9111374 commit 5b40ebc

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/plugins/data/common/search/expressions/phrase_filter.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ describe('interpreter/functions#phraseFilter', () => {
3232
"something",
3333
],
3434
"type": "phrases",
35-
"value": "test, something",
3635
},
3736
"query": Object {
3837
"bool": Object {

src/plugins/data/public/query/filter_manager/lib/get_display_value.test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,10 @@ describe('getDisplayValueFromFilter', () => {
2323
});
2424

2525
it('calls the value function if proivided', () => {
26+
// The type of value currently doesn't match how it's used. Refactor needed.
2627
phraseFilter.meta.value = jest.fn((x) => {
2728
return 'abc';
28-
});
29+
}) as any;
2930
const displayValue = getDisplayValueFromFilter(phraseFilter, [stubIndexPattern]);
3031
expect(displayValue).toBe('abc');
3132
expect(phraseFilter.meta.value).toHaveBeenCalledWith(undefined);
@@ -35,7 +36,7 @@ describe('getDisplayValueFromFilter', () => {
3536
stubIndexPattern.getFormatterForField = jest.fn().mockReturnValue('banana');
3637
phraseFilter.meta.value = jest.fn((x) => {
3738
return x + 'abc';
38-
});
39+
}) as any;
3940
const displayValue = getDisplayValueFromFilter(phraseFilter, [stubIndexPattern]);
4041
expect(stubIndexPattern.getFormatterForField).toHaveBeenCalledTimes(1);
4142
expect(phraseFilter.meta.value).toHaveBeenCalledWith('banana');

0 commit comments

Comments
 (0)