[ML] Fix type error and comments from review

peteharverson · peteharverson · commit 573d9511088f · 2020-03-23T12:56:53.000Z
diff --git a/x-pack/plugins/transform/public/app/sections/create_transform/components/aggregation_list/agg_label_form.tsx b/x-pack/plugins/transform/public/app/sections/create_transform/components/aggregation_list/agg_label_form.tsx
@@ -10,12 +10,7 @@ import { i18n } from '@kbn/i18n';
 
 import { EuiButtonIcon, EuiFlexGroup, EuiFlexItem, EuiPopover } from '@elastic/eui';
 
-import {
-  AggName,
-  isPivotAggsConfigPercentiles,
-  PivotAggsConfig,
-  PivotAggsConfigWithUiSupportDict,
-} from '../../../../common';
+import { AggName, PivotAggsConfig, PivotAggsConfigWithUiSupportDict } from '../../../../common';
 
 import { PopoverForm } from './popover_form';
 
diff --git a/x-pack/plugins/transform/public/app/sections/create_transform/components/aggregation_list/popover_form.tsx b/x-pack/plugins/transform/public/app/sections/create_transform/components/aggregation_list/popover_form.tsx
@@ -46,8 +46,27 @@ function getDefaultPercents(defaultData: PivotAggsConfig): number[] | undefined
   if (isPivotAggsConfigPercentiles(defaultData)) {
     return defaultData.percents;
   }
+}
+
+function parsePercentsInput(inputValue: string | undefined) {
+  if (inputValue !== undefined) {
+    const strVals: string[] = inputValue.split(',');
+    const percents: number[] = [];
+    for (const str of strVals) {
+      if (str.trim().length > 0 && isNaN(str as any) === false) {
+        const val = Number(str);
+        if (val >= 0 && val <= 100) {
+          percents.push(val);
+        } else {
+          return [];
+        }
+      }
+    }
 
-  return undefined;
+    return percents;
+  }
+
+  return [];
 }
 
 function isPercentsInputValid(inputValue: string | undefined) {
@@ -85,12 +104,7 @@ export const PopoverForm: React.FC<Props> = ({ defaultData, otherAggNames, onCha
   }
 
   function updatePercents(inputValue: string) {
-    const isInputValid = isPercentsInputValid(inputValue);
-    if (isInputValid === true) {
-      setPercents(inputValue.split(',').map(Number));
-    } else {
-      setPercents([]);
-    }
+    setPercents(parsePercentsInput(inputValue));
   }
 
   function getUpdatedItem(): PivotAggsConfig {
@@ -153,7 +167,7 @@ export const PopoverForm: React.FC<Props> = ({ defaultData, otherAggNames, onCha
   }
 
   const validPercents =
-    agg === PIVOT_SUPPORTED_AGGS.PERCENTILES && isPercentsInputValid(percentsText);
+    agg === PIVOT_SUPPORTED_AGGS.PERCENTILES && parsePercentsInput(percentsText).length > 0;
 
   let formValid = validAggName;
   if (formValid && agg === PIVOT_SUPPORTED_AGGS.PERCENTILES) {
