Skip to content

Commit 5446dbe

Browse files
byronhulcherConstanceorhantoy
authored
Apply suggestions from code review
Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Orhan Toy <toyorhan@gmail.com>
1 parent b4668d5 commit 5446dbe

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/crawler_status_banner.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ describe('CrawlerStatusBanner', () => {
4545
CrawlerStatus.Suspending,
4646
].forEach((status) => {
4747
describe(`when the status is ${status}`, () => {
48-
it('renders an appropriate CrawlerStatusBanner', () => {
48+
it('does not render a banner/callout', () => {
4949
setMockValues({
5050
mostRecentCrawlRequestStatus: status,
5151
});

x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_overview_logic.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ describe('CrawlerOverviewLogic', () => {
222222
});
223223

224224
describe('on failure', () => {
225-
it('it flashes an error message', async () => {
225+
it('flashes an error message', async () => {
226226
http.post.mockReturnValueOnce(Promise.reject('error'));
227227

228228
CrawlerOverviewLogic.actions.startCrawl();
@@ -250,7 +250,7 @@ describe('CrawlerOverviewLogic', () => {
250250
});
251251

252252
describe('on failure', () => {
253-
it('it flashes an error message', async () => {
253+
it('flashes an error message', async () => {
254254
jest.spyOn(CrawlerOverviewLogic.actions, 'getLatestCrawlRequests');
255255
http.post.mockReturnValueOnce(Promise.reject('error'));
256256

@@ -297,7 +297,7 @@ describe('CrawlerOverviewLogic', () => {
297297
CrawlerStatus.Running,
298298
CrawlerStatus.Canceling,
299299
].forEach((status) => {
300-
it(`Creates a new timeout for status ${status}`, async () => {
300+
it(`creates a new timeout for status ${status}`, async () => {
301301
jest.spyOn(CrawlerOverviewLogic.actions, 'createNewTimeoutForCrawlRequests');
302302
http.get.mockReturnValueOnce(Promise.resolve([{ status }]));
303303

@@ -323,7 +323,7 @@ describe('CrawlerOverviewLogic', () => {
323323
expect(CrawlerOverviewLogic.actions.fetchCrawlerData).toHaveBeenCalled();
324324
});
325325

326-
it(`can optionally supresses fetching data ${status}`, async () => {
326+
it(`optionally supresses fetching data for status ${status}`, async () => {
327327
jest.spyOn(CrawlerOverviewLogic.actions, 'clearTimeoutId');
328328
jest.spyOn(CrawlerOverviewLogic.actions, 'fetchCrawlerData');
329329
http.get.mockReturnValueOnce(Promise.resolve([{ status }]));

0 commit comments

Comments
 (0)