adding ids to saved objects

jgowdyelastic · jgowdyelastic · commit 51bbb2b899db · 2020-11-10T19:10:27.000Z
diff --git a/x-pack/plugins/ml/server/saved_objects/service.ts b/x-pack/plugins/ml/server/saved_objects/service.ts
@@ -58,24 +58,23 @@ export function jobSavedObjectServiceFactory(
 
   async function _createJob(jobType: JobType, jobId: string, datafeedId?: string) {
     await isMlReady();
-    try {
-      await _deleteJob(jobType, jobId);
-    } catch (error) {
-      // fail silently
-      // the job object may or may not already exist, we'll overwrite it anyway.
-    }
-    await savedObjectsClient.create<JobObject>(ML_SAVED_OBJECT_TYPE, {
-      job_id: jobId,
-      datafeed_id: datafeedId ?? null,
-      type: jobType,
-    });
+    await savedObjectsClient.create<JobObject>(
+      ML_SAVED_OBJECT_TYPE,
+      {
+        job_id: jobId,
+        datafeed_id: datafeedId ?? null,
+        type: jobType,
+      },
+      { id: jobId, overwrite: true }
+    );
   }
 
   async function _bulkCreateJobs(jobs: JobObject[], namespaces?: string[]) {
     await isMlReady();
     return await savedObjectsClient.bulkCreate<JobObject>(
       jobs.map((j) => ({
         type: ML_SAVED_OBJECT_TYPE,
+        id: j.job_id,
         attributes: j,
         initialNamespaces: namespaces,
       }))
