Differentiate between Cloud and on-prem scenarios more clearly in Upgrade Step tests.

cjcenizal · cjcenizal · commit 4fc94075fd2e · 2021-08-23T15:19:05.000-07:00
diff --git a/x-pack/plugins/upgrade_assistant/__jest__/client_integration/overview/upgrade_step/upgrade_step.test.tsx b/x-pack/plugins/upgrade_assistant/__jest__/client_integration/overview/upgrade_step/upgrade_step.test.tsx
@@ -23,33 +23,38 @@ describe('Overview - Upgrade Step', () => {
     server.restore();
   });
 
-  test('Shows link to setup upgrade docs for on-prem installations', () => {
-    const { exists } = testBed;
+  describe('On-prem', () => {
+    test('Shows link to setup upgrade docs', () => {
+      const { exists } = testBed;
 
-    expect(exists('upgradeSetupDocsLink')).toBe(true);
-    expect(exists('upgradeSetupCloudLink')).toBe(false);
+      expect(exists('upgradeSetupDocsLink')).toBe(true);
+      expect(exists('upgradeSetupCloudLink')).toBe(false);
+    });
   });
 
-  test('Shows upgrade CTA and link to docs for cloud installations', async () => {
-    await act(async () => {
-      testBed = await setupOverviewPage({
-        kibanaContextOverrides: {
-          cloud: {
-            isCloudEnabled: true,
-            deploymentUrl: 'https://cloud.elastic.co./deployments/bfdad4ef99a24212a06d387593686d63',
+  describe('On Cloud', () => {
+    test('Shows upgrade CTA and link to docs', async () => {
+      await act(async () => {
+        testBed = await setupOverviewPage({
+          kibanaContextOverrides: {
+            cloud: {
+              isCloudEnabled: true,
+              deploymentUrl:
+                'https://cloud.elastic.co./deployments/bfdad4ef99a24212a06d387593686d63',
+            },
           },
-        },
+        });
       });
-    });
 
-    const { component, exists, find } = testBed;
-    component.update();
+      const { component, exists, find } = testBed;
+      component.update();
 
-    expect(exists('upgradeSetupCloudLink')).toBe(true);
-    expect(exists('upgradeSetupDocsLink')).toBe(true);
+      expect(exists('upgradeSetupDocsLink')).toBe(true);
+      expect(exists('upgradeSetupCloudLink')).toBe(true);
 
-    expect(find('upgradeSetupCloudLink').props().href).toBe(
-      'https://cloud.elastic.co./deployments/bfdad4ef99a24212a06d387593686d63'
-    );
+      expect(find('upgradeSetupCloudLink').props().href).toBe(
+        'https://cloud.elastic.co./deployments/bfdad4ef99a24212a06d387593686d63'
+      );
+    });
   });
 });
