Skip to content

Commit 44fb7ef

Browse files
author
oatkiller
committed
second round of disabling rules on a per-line basis.
1 parent 3e00900 commit 44fb7ef

3 files changed

Lines changed: 7 additions & 0 deletions

File tree

x-pack/plugins/infra/public/components/alerting/inventory/expression.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ export const Expressions: React.FC<Props> = (props) => {
117117
timeUnit: timeUnit ?? defaultExpression.timeUnit,
118118
});
119119
setAlertParams('criteria', exp);
120+
/* eslint-disable-next-line react-hooks/exhaustive-deps */
120121
}, [setAlertParams, alertParams.criteria, timeSize, timeUnit]);
121122

122123
const removeExpression = useCallback(
@@ -141,6 +142,7 @@ export const Expressions: React.FC<Props> = (props) => {
141142
[derivedIndexPattern, setAlertParams]
142143
);
143144

145+
/* eslint-disable-next-line react-hooks/exhaustive-deps */
144146
const debouncedOnFilterChange = useCallback(debounce(onFilterChange, FILTER_TYPING_DEBOUNCE_MS), [
145147
onFilterChange,
146148
]);

x-pack/plugins/infra/public/components/alerting/logs/expression_editor/editor.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ export const Editor: React.FC<Props> = (props) => {
137137
} else {
138138
return [];
139139
}
140+
/* eslint-disable-next-line react-hooks/exhaustive-deps */
140141
}, [sourceStatus]);
141142

142143
const updateCount = useCallback(
@@ -176,6 +177,7 @@ export const Editor: React.FC<Props> = (props) => {
176177
? [...alertParams.criteria, DEFAULT_CRITERIA]
177178
: [DEFAULT_CRITERIA];
178179
setAlertParams('criteria', nextCriteria);
180+
/* eslint-disable-next-line react-hooks/exhaustive-deps */
179181
}, [alertParams, setAlertParams]);
180182

181183
const removeCriterion = useCallback(
@@ -185,6 +187,7 @@ export const Editor: React.FC<Props> = (props) => {
185187
});
186188
setAlertParams('criteria', nextCriteria);
187189
},
190+
/* eslint-disable-next-line react-hooks/exhaustive-deps */
188191
[alertParams, setAlertParams]
189192
);
190193

x-pack/plugins/infra/public/components/header/header.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,12 @@ export const Header = ({ breadcrumbs = [], readOnlyBadge = false }: HeaderProps)
3131

3232
const setBreadcrumbs = useCallback(() => {
3333
return chrome?.setBreadcrumbs(breadcrumbs || []);
34+
/* eslint-disable-next-line react-hooks/exhaustive-deps */
3435
}, [breadcrumbs, chrome]);
3536

3637
const setBadge = useCallback(() => {
3738
return chrome?.setBadge(badge);
39+
/* eslint-disable-next-line react-hooks/exhaustive-deps */
3840
}, [badge, chrome]);
3941

4042
useEffect(() => {

0 commit comments

Comments
 (0)