Skip to content

Commit 439366d

Browse files
mbondyrambondyra
authored
Merge branch 'main' into lens/rtl
2 parents c89c3d0 + a2235c8 commit 439366d

267 files changed

Lines changed: 7843 additions & 2738 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.buildkite/scripts/steps/functional/performance_playwright.sh‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,13 @@ if [ "$BUILDKITE_PIPELINE_SLUG" == "kibana-performance-data-set-extraction" ]; t
3939
node scripts/run_performance.js --kibana-install-dir "$KIBANA_BUILD_LOCATION" --skip-warmup
4040
else
4141
# pipeline should use bare metal static worker
42-
echo "--- Running performance tests"
43-
node scripts/run_performance.js --kibana-install-dir "$KIBANA_BUILD_LOCATION"
42+
if [[ -z "${JOURNEYS_GROUP+x}" ]]; then
43+
echo "--- Running performance tests"
44+
node scripts/run_performance.js --kibana-install-dir "$KIBANA_BUILD_LOCATION"
45+
else
46+
echo "--- Running performance tests: '$JOURNEYS_GROUP' group"
47+
node scripts/run_performance.js --kibana-install-dir "$KIBANA_BUILD_LOCATION" --group "$JOURNEYS_GROUP"
48+
fi
4449
fi
4550

4651
echo "--- Upload journey step screenshots"

‎.devcontainer/.env.template‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# /bin/bash or /bin/zsh (oh-my-zsh is installed by default as well)
22
SHELL=/bin/bash
3-
# Switch to 1 to enable FIPS environment, any other value to disable
3+
# Switch to 1 to enable FIPS environment, any other value to disable,
4+
# then close and reopen a new terminal to setup the environment
45
FIPS=0

‎.devcontainer/Dockerfile‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,9 @@ WORKDIR ${KBN_DIR}
4949

5050
# Node and NVM setup
5151
COPY .node-version /tmp/
52+
53+
USER vscode
54+
5255
RUN mkdir -p $NVM_DIR && \
5356
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/${NVM_VERSION}/install.sh | bash && \
5457
. "$NVM_DIR/nvm.sh" && \
@@ -61,6 +64,8 @@ RUN mkdir -p $NVM_DIR && \
6164
echo "source $NVM_DIR/nvm.sh" >> ${HOME}/.zshrc && \
6265
chown -R 1000:1000 "${HOME}/.npm"
6366

67+
USER root
68+
6469
# Reload the env everytime a new shell is opened incase the .env file changed.
6570
RUN echo "source $KBN_DIR/.devcontainer/scripts/env.sh" >> ${HOME}/.bashrc && \
6671
echo "source $KBN_DIR/.devcontainer/scripts/env.sh" >> ${HOME}/.zshrc

‎dev_docs/tutorials/performance/adding_performance_journey.mdx‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,27 @@ simulate real life internet connection. This means that all requests have a fixe
8989
In order to keep track on performance metrics stability, journeys are run on main branch with a scheduled interval.
9090
Bare metal machine is used to produce results as stable and reproducible as possible.
9191

92+
#### Running subset of journeys for the PR
93+
94+
Some code changes might affect the Kibana performance and it might be benefitial to run relevant journeys against the PR
95+
and compare performance metrics vs. the ones on main branch.
96+
97+
In oder to trigger the build for Kibana PR, you can follow these steps:
98+
99+
- Create a new kibana-single-user-performance [build](https://buildkite.com/elastic/kibana-single-user-performance#new)
100+
- Provide the following arguments:
101+
- Branch: `refs/pull/<PR_number>/head`
102+
- Under Options, set the environment variable: `JOURNEYS_GROUP=<group_name>`
103+
104+
Currently supported journey groups:
105+
106+
- kibanaStartAndLoad
107+
- crud
108+
- dashboard
109+
- discover
110+
- maps
111+
- ml
112+
92113
#### Machine specifications
93114

94115
All benchmarks are run on bare-metal machines with the [following specifications](https://www.hetzner.com/dedicated-rootserver/ex100):

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1801,7 +1801,7 @@
18011801
"tape": "^5.0.1",
18021802
"terser": "^5.32.0",
18031803
"terser-webpack-plugin": "^4.2.3",
1804-
"tough-cookie": "^4.1.4",
1804+
"tough-cookie": "^5.0.0",
18051805
"tree-kill": "^1.2.2",
18061806
"ts-morph": "^15.1.0",
18071807
"tsd": "^0.31.1",

‎packages/kbn-esql-ast/src/antlr_error_listener.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { ErrorListener } from 'antlr4';
1212
import type { EditorError } from './types';
1313
import { getPosition } from './ast_position_utils';
1414

15-
const REPLACE_DEV = /,*\s*DEV_\w+\s*/g;
15+
const REPLACE_DEV = /,{0,1}(?<!\s)\s*DEV_\w+\s*/g;
1616
export class ESQLErrorListener extends ErrorListener<any> {
1717
protected errors: EditorError[] = [];
1818

‎packages/kbn-optimizer/limits.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ pageLoadAssetSize:
119119
observabilityAiAssistantManagement: 19279
120120
observabilityLogsExplorer: 46650
121121
observabilityOnboarding: 19573
122-
observabilityShared: 72039
122+
observabilityShared: 80000
123123
osquery: 107090
124124
painlessLab: 179748
125125
presentationPanel: 55463

‎packages/kbn-securitysolution-endpoint-exceptions-common/api/create_endpoint_list/create_endpoint_list.schema.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ paths:
88
x-labels: [serverless, ess]
99
x-codegen-enabled: true
1010
operationId: CreateEndpointList
11-
summary: Creates an endpoint list
12-
description: Creates an endpoint list or does nothing if the list already exists
11+
summary: Create an endpoint exception list
12+
description: Create an endpoint exception list, which groups endpoint exception list items. If an endpoint exception list already exists, an empty response is returned.
1313
responses:
1414
200:
1515
description: Successful response

‎packages/kbn-securitysolution-endpoint-exceptions-common/api/create_endpoint_list_item/create_endpoint_list_item.schema.yaml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ paths:
88
x-labels: [serverless, ess]
99
x-codegen-enabled: true
1010
operationId: CreateEndpointListItem
11-
summary: Creates an endpoint list item
11+
summary: Create an endpoint exception list item
12+
description: Create an endpoint exception list item, and associate it with the endpoint exception list.
1213
requestBody:
1314
description: Exception list item's properties
1415
required: true

‎packages/kbn-securitysolution-endpoint-exceptions-common/api/delete_endpoint_list_item/delete_endpoint_list_item.schema.yaml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ paths:
88
x-labels: [serverless, ess]
99
x-codegen-enabled: true
1010
operationId: DeleteEndpointListItem
11-
summary: Deletes an endpoint list item
11+
summary: Delete an endpoint exception list item
12+
description: Delete an endpoint exception list item using the `id` or `item_id` field.
1213
parameters:
1314
- name: id
1415
in: query

0 commit comments

Comments
 (0)