[AI4DSOC] Fix logic that renders the group title when grouping by integrations

PhilippeOberti · PhilippeOberti · commit 40da239f5ed6 · 2025-04-28T11:28:54.000-05:00
diff --git a/x-pack/solutions/security/plugins/security_solution/public/detections/hooks/alert_summary/use_get_integration_from_rule_id.test.ts b/x-pack/solutions/security/plugins/security_solution/public/detections/hooks/alert_summary/use_get_integration_from_rule_id.test.ts
@@ -26,6 +26,30 @@ describe('useGetIntegrationFromRuleId', () => {
     expect(result.current.integration).toBe(undefined);
   });
 
+  it('should return undefined integration when the rule does not have the expected related_integrations', () => {
+    const packages: PackageListItem[] = [
+      {
+        id: 'splunk',
+        icons: [{ src: 'icon.svg', path: 'mypath/icon.svg', type: 'image/svg+xml' }],
+        name: 'splunk',
+        status: installationStatuses.NotInstalled,
+        title: 'Splunk',
+        version: '0.1.0',
+      },
+    ];
+    const ruleId = 'rule_id';
+    const rules: RuleResponse[] = [
+      {
+        id: 'rule_id',
+        related_integrations: [{ package: 'wrong_integrations' }],
+      } as RuleResponse,
+    ];
+
+    const { result } = renderHook(() => useGetIntegrationFromRuleId({ packages, ruleId, rules }));
+
+    expect(result.current.integration).toBe(undefined);
+  });
+
   it('should render a matching integration', () => {
     const packages: PackageListItem[] = [
       {
@@ -38,7 +62,12 @@ describe('useGetIntegrationFromRuleId', () => {
       },
     ];
     const ruleId = 'rule_id';
-    const rules: RuleResponse[] = [{ id: 'rule_id', name: 'splunk' } as RuleResponse];
+    const rules: RuleResponse[] = [
+      {
+        id: 'rule_id',
+        related_integrations: [{ package: 'splunk' }],
+      } as RuleResponse,
+    ];
 
     const { result } = renderHook(() => useGetIntegrationFromRuleId({ packages, ruleId, rules }));
 
diff --git a/x-pack/solutions/security/plugins/security_solution/public/detections/hooks/alert_summary/use_get_integration_from_rule_id.ts b/x-pack/solutions/security/plugins/security_solution/public/detections/hooks/alert_summary/use_get_integration_from_rule_id.ts
@@ -51,7 +51,7 @@ export const useGetIntegrationFromRuleId = ({
       return undefined;
     }
 
-    return packages.find((p) => p.name === rule.name);
+    return packages.find((p) => rule.related_integrations.map((ri) => ri.package).includes(p.name));
   }, [packages, rules, ruleId]);
 
   return useMemo(

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ export const useGetIntegrationFromRuleId = ({`
`51`	`51`	`return undefined;`
`52`	`52`	`}`
`53`	`53`
`54`		`- return packages.find((p) => p.name === rule.name);`
	`54`	`+ return packages.find((p) => rule.related_integrations.map((ri) => ri.package).includes(p.name));`
`55`	`55`	`}, [packages, rules, ruleId]);`
`56`	`56`
`57`	`57`	`return useMemo(`