Skip to content

Commit 3c93f7f

Browse files
committed
addressing PR comment
1 parent dc2e588 commit 3c93f7f

2 files changed

Lines changed: 726 additions & 416 deletions

File tree

x-pack/plugins/apm/server/lib/service_map/get_service_map_from_trace_ids.test.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -172,14 +172,16 @@ describe('getConnections', () => {
172172
environment: 'ENVIRONMENT_NOT_DEFINED',
173173
});
174174

175-
const environments = new Set();
176-
177-
connections.forEach((conn) =>
178-
environments.add(conn.source['service.environment'])
179-
);
180-
expect(
181-
connections.some((conn) => conn.source['service.environment'] !== null)
182-
).toBeFalsy();
175+
const connectionsPairs = getConnectionsPairs(connections);
176+
expect(connectionsPairs).toEqual([
177+
'opbeans-go:null -> opbeans-java:null',
178+
'opbeans-node:null -> opbeans-python:null',
179+
'opbeans-node:null -> opbeans-ruby:null',
180+
'opbeans-python:null -> opbeans-node:null',
181+
'opbeans-python:null -> opbeans-ruby:null',
182+
'opbeans-ruby:null -> opbeans-node:null',
183+
'opbeans-ruby:null -> opbeans-python:null',
184+
]);
183185
});
184186
});
185187
});

0 commit comments

Comments
 (0)