Fixing failing functional test

Maja Grubic · Maja Grubic · commit 37efd6e179eb · 2019-10-17T19:00:54.000+01:00
diff --git a/src/legacy/core_plugins/kibana/public/discover/components/field_chooser/discover_field_search.tsx b/src/legacy/core_plugins/kibana/public/discover/components/field_chooser/discover_field_search.tsx
@@ -190,7 +190,7 @@ export function DiscoverFieldSearch({ onChange, value, types }: Props) {
 
   const selectionPanel = (
     <div className="dscFieldSearch__formWrapper">
-      <EuiForm>
+      <EuiForm data-test-subj="filterSelectionPanel">
         <EuiFormRow
           fullWidth
           label={i18n.translate('kbn.discover.fieldChooser.filter.aggregatableLabel', {
diff --git a/test/functional/page_objects/discover_page.js b/test/functional/page_objects/discover_page.js
@@ -283,19 +283,13 @@ export function DiscoverPageProvider({ getService, getPageObjects }) {
     }
 
     async openSidebarFieldFilter() {
-      const fieldFilterFormExists = await testSubjects.exists('discoverFieldFilter');
-      if (!fieldFilterFormExists) {
-        await testSubjects.click('toggleFieldFilterButton');
-        await testSubjects.existOrFail('discoverFieldFilter');
-      }
+      await testSubjects.click('toggleFieldFilterButton');
+      await testSubjects.existOrFail('filterSelectionPanel');
     }
 
     async closeSidebarFieldFilter() {
-      const fieldFilterFormExists = await testSubjects.exists('discoverFieldFilter');
-      if (fieldFilterFormExists) {
-        await testSubjects.click('toggleFieldFilterButton');
-        await testSubjects.missingOrFail('discoverFieldFilter', { allowHidden: true });
-      }
+      await testSubjects.click('toggleFieldFilterButton');
+      await testSubjects.missingOrFail('filterSelectionPanel', { allowHidden: true });
     }
 
   }

Original file line number	Diff line number	Diff line change
`@@ -283,19 +283,13 @@ export function DiscoverPageProvider({ getService, getPageObjects }) {`
`283`	`283`	`}`
`284`	`284`
`285`	`285`	`async openSidebarFieldFilter() {`
`286`		`- const fieldFilterFormExists = await testSubjects.exists('discoverFieldFilter');`
`287`		`- if (!fieldFilterFormExists) {`
`288`		`- await testSubjects.click('toggleFieldFilterButton');`
`289`		`- await testSubjects.existOrFail('discoverFieldFilter');`
`290`		`- }`
	`286`	`+ await testSubjects.click('toggleFieldFilterButton');`
	`287`	`+ await testSubjects.existOrFail('filterSelectionPanel');`
`291`	`288`	`}`
`292`	`289`
`293`	`290`	`async closeSidebarFieldFilter() {`
`294`		`- const fieldFilterFormExists = await testSubjects.exists('discoverFieldFilter');`
`295`		`- if (fieldFilterFormExists) {`
`296`		`- await testSubjects.click('toggleFieldFilterButton');`
`297`		`- await testSubjects.missingOrFail('discoverFieldFilter', { allowHidden: true });`
`298`		`- }`
	`291`	`+ await testSubjects.click('toggleFieldFilterButton');`
	`292`	`+ await testSubjects.missingOrFail('filterSelectionPanel', { allowHidden: true });`
`299`	`293`	`}`
`300`	`294`
`301`	`295`	`}`