PR Feedback: Rename log_settings

JasonStoltz · JasonStoltz · commit 361cfea075a7 · 2020-11-03T10:26:10.000-05:00
diff --git a/x-pack/plugins/enterprise_search/server/plugin.ts b/x-pack/plugins/enterprise_search/server/plugin.ts
@@ -41,7 +41,7 @@ import { appSearchTelemetryType } from './saved_objects/app_search/telemetry';
 import { registerTelemetryUsageCollector as registerASTelemetryUsageCollector } from './collectors/app_search/telemetry';
 import { registerEnginesRoute } from './routes/app_search/engines';
 import { registerCredentialsRoutes } from './routes/app_search/credentials';
-import { registerLogSettingsRoutes } from './routes/app_search/log_settings';
+import { registerSettingsRoutes } from './routes/app_search/settings';
 
 import { workplaceSearchTelemetryType } from './saved_objects/workplace_search/telemetry';
 import { registerTelemetryUsageCollector as registerWSTelemetryUsageCollector } from './collectors/workplace_search/telemetry';
@@ -129,7 +129,7 @@ export class EnterpriseSearchPlugin implements Plugin {
     registerConfigDataRoute(dependencies);
     registerEnginesRoute(dependencies);
     registerCredentialsRoutes(dependencies);
-    registerLogSettingsRoutes(dependencies);
+    registerSettingsRoutes(dependencies);
     registerWSOverviewRoute(dependencies);
     registerWSGroupRoutes(dependencies);
 
diff --git a/x-pack/plugins/enterprise_search/server/routes/app_search/settings.test.ts b/x-pack/plugins/enterprise_search/server/routes/app_search/settings.test.ts
@@ -6,7 +6,7 @@
 
 import { MockRouter, mockRequestHandler, mockDependencies } from '../../__mocks__';
 
-import { registerLogSettingsRoutes } from './log_settings';
+import { registerSettingsRoutes } from './settings';
 
 describe('log settings routes', () => {
   describe('PUT /api/app_search/log_settings', () => {
@@ -16,7 +16,7 @@ describe('log settings routes', () => {
       jest.clearAllMocks();
       mockRouter = new MockRouter({ method: 'put', payload: 'body' });
 
-      registerLogSettingsRoutes({
+      registerSettingsRoutes({
         ...mockDependencies,
         router: mockRouter.router,
       });
@@ -57,7 +57,7 @@ describe('log settings routes', () => {
       jest.clearAllMocks();
       mockRouter = new MockRouter({ method: 'get' });
 
-      registerLogSettingsRoutes({
+      registerSettingsRoutes({
         ...mockDependencies,
         router: mockRouter.router,
       });
diff --git a/x-pack/plugins/enterprise_search/server/routes/app_search/settings.ts b/x-pack/plugins/enterprise_search/server/routes/app_search/settings.ts
@@ -8,7 +8,7 @@ import { schema } from '@kbn/config-schema';
 
 import { IRouteDependencies } from '../../plugin';
 
-export function registerLogSettingsRoutes({
+export function registerSettingsRoutes({
   router,
   enterpriseSearchRequestHandler,
 }: IRouteDependencies) {
