Skip to content

Commit 35ce70d

Browse files
kertalkertal
committed
Refactor saved object management registry usage (#54155)
* Migrate registry to TypeScript * Migrate management code * Migrate SavedObjectLoader services registration to management section * Replace Angular SavedSearchLoader in transform plugin * Migrate saved_visualizations from visualize to visualizations plugin
1 parent 82509cb commit 35ce70d

33 files changed

Lines changed: 164 additions & 268 deletions

File tree

‎src/legacy/core_plugins/kibana/index.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ export default function(kibana) {
6464
'plugins/kibana/visualize/legacy',
6565
'plugins/kibana/dashboard/legacy',
6666
],
67-
savedObjectTypes: ['plugins/kibana/dashboard/saved_dashboard/saved_dashboard_register'],
6867
app: {
6968
id: 'kibana',
7069
title: 'Kibana',

‎src/legacy/core_plugins/kibana/public/dashboard/__tests__/saved_dashboards.js‎

Lines changed: 0 additions & 36 deletions
This file was deleted.

‎src/legacy/core_plugins/kibana/public/dashboard/index.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import { PluginInitializerContext } from 'kibana/public';
2121
import { DashboardPlugin } from './plugin';
2222

2323
export * from './np_ready/dashboard_constants';
24+
export { createSavedDashboardLoader } from './saved_dashboard/saved_dashboards';
2425

2526
// Core will be looking for this when loading our plugin in the new platform
2627
export const plugin = (context: PluginInitializerContext) => {

‎src/legacy/core_plugins/kibana/public/dashboard/legacy.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import { npSetup, npStart, legacyChrome } from './legacy_imports';
2222
import { LegacyAngularInjectedDependencies } from './plugin';
2323
import { start as data } from '../../../data/public/legacy';
2424
import { start as embeddables } from '../../../embeddable_api/public/np_ready/public/legacy';
25-
import './saved_dashboard/saved_dashboard_register';
2625
import './dashboard_config';
2726
import { plugin } from './index';
2827

‎src/legacy/core_plugins/kibana/public/dashboard/saved_dashboard/saved_dashboard_register.ts‎

Lines changed: 0 additions & 46 deletions
This file was deleted.

‎src/legacy/core_plugins/kibana/public/discover/build_services.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import {
3030
IndexPatternsContract,
3131
DataPublicPluginStart,
3232
} from 'src/plugins/data/public';
33-
import { createSavedSearchesService } from './saved_searches';
33+
import { createSavedSearchesLoader } from './saved_searches';
3434
import { DiscoverStartPlugins } from './plugin';
3535
import { EuiUtilsStart } from '../../../../../plugins/eui_utils/public';
3636
import { SharePluginStart } from '../../../../../plugins/share/public';
@@ -68,7 +68,7 @@ export async function buildServices(
6868
chrome: core.chrome,
6969
overlays: core.overlays,
7070
};
71-
const savedObjectService = createSavedSearchesService(services);
71+
const savedObjectService = createSavedSearchesLoader(services);
7272
return {
7373
addBasePath: core.http.basePath.prepend,
7474
capabilities: core.application.capabilities,

‎src/legacy/core_plugins/kibana/public/discover/index.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import { PluginInitializerContext } from 'kibana/public';
2121
import { DiscoverPlugin } from './plugin';
2222

23-
export { createSavedSearchesService } from './saved_searches/saved_searches';
23+
export { createSavedSearchesLoader } from './saved_searches/saved_searches';
2424

2525
// Core will be looking for this when loading our plugin in the new platform
2626
export const plugin = (context: PluginInitializerContext) => {

‎src/legacy/core_plugins/kibana/public/discover/saved_searches/index.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,3 @@
1818
*/
1919

2020
export * from './saved_searches';
21-
import './saved_searches_register';

‎src/legacy/core_plugins/kibana/public/discover/saved_searches/saved_searches.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import { SavedObjectLoader } from 'ui/saved_objects';
2020
import { SavedObjectKibanaServices } from 'ui/saved_objects/types';
2121
import { createSavedSearchClass } from './_saved_search';
2222

23-
export function createSavedSearchesService(services: SavedObjectKibanaServices) {
23+
export function createSavedSearchesLoader(services: SavedObjectKibanaServices) {
2424
const SavedSearchClass = createSavedSearchClass(services);
2525
const savedSearchLoader = new SavedObjectLoader(
2626
SavedSearchClass,

‎src/legacy/core_plugins/kibana/public/discover/saved_searches/saved_searches_register.ts‎

Lines changed: 0 additions & 43 deletions
This file was deleted.

0 commit comments

Comments
 (0)