Skip to content

Commit 33f62ae

Browse files
alexwizpalexwizp
committed
Address @elastic/eui/require-table-caption lint violations across @elastic/security-threat-hunting files
1 parent b8a2135 commit 33f62ae

6 files changed

Lines changed: 22 additions & 0 deletions

File tree

‎x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/dashboard_table/index.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ import { useGetMigrationTranslationStats } from '../../logic/use_get_migration_t
4747
import { useMigrationDashboardDetailsFlyout } from '../../hooks/use_migration_dashboard_details_flyout';
4848
import { useStartDashboardsMigrationModal } from '../../hooks/use_start_dashboard_migration_modal';
4949
import { useStartMigration } from '../../logic/use_start_migration';
50+
import { DASHBOARD_MIGRATION_TABLE_CAPTION, MIGRATION_DASHBOARD_TABLE_TABLE } from './translations';
5051

5152
const DEFAULT_PAGE_SIZE = 10;
5253
const DEFAULT_SORT_FIELD = 'translation_result';
@@ -321,6 +322,7 @@ export const MigrationDashboardsTable: React.FC<MigrationDashboardsTableProps> =
321322
</EuiFlexGroup>
322323
<EuiSpacer size="m" />
323324
<EuiBasicTable<DashboardMigrationDashboard>
325+
tableCaption={i18n.DASHBOARDS_MIGRATION_TABLE_CAPTION}
324326
loading={false}
325327
items={migrationDashboards}
326328
pagination={pagination}

‎x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/dashboard_table/translations.ts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,10 @@ export const NOT_TRANSLATED_DASHBOARD_TOOLTIP = i18n.translate(
2020
defaultMessage: 'Not translated migration dashboard',
2121
}
2222
);
23+
24+
export const DASHBOARDS_MIGRATION_TABLE_CAPTION = i18n.translate(
25+
'xpack.securitySolution.siemMigrations.dashboards.table.caption',
26+
{
27+
defaultMessage: 'Dashboards migration status',
28+
}
29+
);

‎x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/migration_status_panels/migration_result_panel.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ import { MigrationsLastError } from '../../../common/components/migration_panels
4141
import { MigrationPanelTitle } from '../../../common/components/migration_panels/migration_title';
4242
import { useCompleteBadgeStyles } from '../../../common/hooks/use_complete_status_badge_styles';
4343
import { TotalExecutionTime } from '../../../common/components/total_execution_time';
44+
import { DASHBOARD_MIGRATION_SUMMARY_TITLE } from './translations';
4445

4546
const headerStyle = css`
4647
&:hover {
@@ -306,6 +307,7 @@ const TranslationResultsTable = React.memo<{
306307
items={items}
307308
columns={columns}
308309
compressed
310+
tableCaption={i18n.DASHBOARD_MIGRATION_SUMMARY_TITLE}
309311
/>
310312
);
311313
});

‎x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/migration_status_panels/migration_result_panel.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ import { RuleMigrationsUploadMissingPanel } from './upload_missing_panel';
4242
import { MigrationsLastError } from '../../../common/components/migration_panels/last_error';
4343
import { MigrationPanelTitle } from '../../../common/components/migration_panels/migration_title';
4444
import { TotalExecutionTime } from '../../../common/components/total_execution_time';
45+
import { RULE_MIGRATION_SUMMARY_TITLE } from './translations';
4546

4647
const headerStyle = css`
4748
&:hover {
@@ -309,6 +310,7 @@ const TranslationResultsTable = React.memo<{
309310
data-test-subj="translatedResultsTable"
310311
items={items}
311312
columns={columns}
313+
tableCaption={i18n.RULE_MIGRATION_SUMMARY_TITLE}
312314
compressed
313315
/>
314316
);

‎x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/rules_table/index.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ import {
5454
} from '../../../../common/components/utility_bar';
5555
import { useStartRulesMigrationModal } from '../../hooks/use_start_rules_migration_modal';
5656
import { useStartMigration } from '../../logic/use_start_migration';
57+
import { RULES_MIGRAION_TABLE_CAPTION, RULES_MIGRATION_TABLE_CAPTION } from './translations';
5758

5859
const DEFAULT_PAGE_SIZE = 10;
5960
const DEFAULT_SORT_FIELD = 'translation_result';
@@ -452,6 +453,7 @@ export const MigrationRulesTable: React.FC<MigrationRulesTableProps> = React.mem
452453
itemId={'id'}
453454
data-test-subj={'rules-translation-table'}
454455
columns={rulesColumns}
456+
tableCaption={i18n.RULES_MIGRATION_TABLE_CAPTION}
455457
/>
456458
</>
457459
)

‎x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/rules_table/translations.ts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,13 @@
77

88
import { i18n } from '@kbn/i18n';
99

10+
export const RULES_MIGRATION_TABLE_CAPTION = i18n.translate(
11+
'xpack.securitySolution.siemMigrations.rules.table.caption',
12+
{
13+
defaultMessage: 'Rules migration status',
14+
}
15+
);
16+
1017
export const ALREADY_TRANSLATED_RULE_TOOLTIP = i18n.translate(
1118
'xpack.securitySolution.siemMigrations.rules.table.alreadyTranslatedTooltip',
1219
{

0 commit comments

Comments
 (0)