[Dashboard] Save button is disabled in case of save error (#227091)

olapawlus · web-flow · commit 326460bf84b2 · 2025-07-09T10:14:06.000+02:00
Closes #221579 Added an early return to ensure the `hasUnsavedChanges` flag remains true when `saveDashboardState` returns an error. The video below shows the behavior after the fix. https://github.com/user-attachments/assets/c6a1d914-6030-44a3-bcd5-2b801d78b97a
diff --git a/src/platform/plugins/shared/dashboard/public/dashboard_api/get_dashboard_api.ts b/src/platform/plugins/shared/dashboard/public/dashboard_api/get_dashboard_api.ts
@@ -205,6 +205,7 @@ export function getDashboardApi({
         lastSavedId: savedObjectId$.value,
       });
 
+      if (saveResult?.error) return;
       unsavedChangesManager.internalApi.onSave(dashboardState, searchSourceReferences);
       references$.next(saveResult.references);
 
